public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] message fix of scsi_mod.
@ 2004-03-31 12:31 Hironobu Ishii
  0 siblings, 0 replies; only message in thread
From: Hironobu Ishii @ 2004-03-31 12:31 UTC (permalink / raw)
  To: James Bottomley; +Cc: linux-scsi

Hi James,

This patch:
    - fixes a message it does not tell us the error device.
    - fixes weird messages from scsi_sysfs.c

This is a patch for linux-2.6.5-rc3.

Please apply!

Thanks,
Hironobu Ishii.

diff -urN linux-2.6.5-rc3/drivers/scsi/scsi_scan.c linux-2.6.5-rc3-work/drivers/scsi/scsi_scan.c
--- linux-2.6.5-rc3/drivers/scsi/scsi_scan.c 2004-03-30 19:02:47.000000000 +0900
+++ linux-2.6.5-rc3-work/drivers/scsi/scsi_scan.c 2004-03-31 19:12:37.195529071 +0900
@@ -403,10 +403,12 @@
    /* if the longer inquiry has failed, flag the device
     * as only accepting 36 byte inquiries and retry the
     * 36 byte inquiry */
-   printk(KERN_INFO "scsi scan: %d byte inquiry failed"
-          " with code %d.  Consider BLIST_INQUIRY_36 for"
-          " this device\n", possible_inq_resp_len,
-          sreq->sr_result);
+   printk(KERN_INFO "scsi scan: <%d:%d:%d:%d>: "
+          "%d byte inquiry failed with code %d.  "
+          "Consider BLIST_INQUIRY_36 for this device\n",
+          sdev->host->host_no, sdev->channel,
+          sdev->id, sdev->lun,
+          possible_inq_resp_len, sreq->sr_result);
    *bflags = BLIST_INQUIRY_36;
    goto repeat_inquiry;
   }
diff -urN linux-2.6.5-rc3/drivers/scsi/scsi_sysfs.c linux-2.6.5-rc3-work/drivers/scsi/scsi_sysfs.c
--- linux-2.6.5-rc3/drivers/scsi/scsi_sysfs.c 2004-03-30 19:02:47.000000000 +0900
+++ linux-2.6.5-rc3-work/drivers/scsi/scsi_sysfs.c 2004-03-31 19:20:15.990455170 +0900
@@ -358,13 +358,15 @@
 
  error = device_add(&sdev->sdev_gendev);
  if (error) {
-  printk(KERN_INFO "error 1\n");
+  printk(KERN_INFO "scsi_sysfs: device_add() failed on <%d:%d:%d:%d>\n",
+   sdev->host->host_no, sdev->channel, sdev->id, sdev->lun );
   return error;
  }
 
  error = class_device_add(&sdev->sdev_classdev);
  if (error) {
-  printk(KERN_INFO "error 2\n");
+  printk(KERN_INFO "scsi_sysfs: class_device_add failed on <%d:%d:%d:%d>\n",
+   sdev->host->host_no, sdev->channel, sdev->id, sdev->lun);
   goto clean_device;
  }
  /* take a reference for the sdev_classdev; this is


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2004-03-31 12:33 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-03-31 12:31 [PATCH] message fix of scsi_mod Hironobu Ishii

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox