From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C885D25743D for ; Thu, 24 Jul 2025 09:55:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753350924; cv=none; b=nDXRmfqKDtNwQGWxZe4f7MFHgRDpvGLZeQOseTF1Iv/sFNQiIM0v2OinKTHbma88LN1l9JV+SCVASoSXMSBf9NXOWOtsLtUw6ZHrK/ZZUlLeh+i9o1eSQftPbXAYGmIBnGUbvlIp07L5KKYZulYvZ2kmCW3IK5fdfDpVcPvrcJE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753350924; c=relaxed/simple; bh=ttx1sn8LRJJ7tFRoMIFeaQa8OLFqq3HWpSLFnn0BMsM=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=JIslGlIEv7gfLJq7PNOlcP24uJ0q5+LR1l2jN1VQaPLllrvFfptLoSsDCfU16lAFYqBTzeCZEI9zRemr2W97riA12g1wJO0dr0qn4MvQC/JbmQO8ix3/82OAJt/mEhbtlicLbkHUOwxV2e0tZXhoGltquHC7E0api15tZ6+ixk8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=e/lAKvXk; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="e/lAKvXk" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-45622a1829eso2427225e9.1 for ; Thu, 24 Jul 2025 02:55:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1753350921; x=1753955721; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=ttx1sn8LRJJ7tFRoMIFeaQa8OLFqq3HWpSLFnn0BMsM=; b=e/lAKvXkgPfr3bvUnr7si/NEmjRxLq234D/1igBvzqyxZSAp7LjD41+/EyuFiK1qsE spfey5/tseazXT1fzkU6DbqSH6kAas5II5RWTezbZVkMrXh5h/ovDK4HKHTc+1qTXHuF PE23IBBtK4yWG4C+dSMr9B+gH163HtDIsrxzD1Q2Qep12Sof8gHvo4VtKcvWz24IoWSL xS7XhRBK7RV7dhK95Ka0VIQppag42yQm12cKbatIwRb1hThmqwaolYRAf8rULNeSKlIe dgnxah8N3NaYL3h0D20AOyYUx2Cb2DVhL1xMHkWawadacToNkn7zCe1ETZMSVLT3rDfD aDPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753350921; x=1753955721; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=ttx1sn8LRJJ7tFRoMIFeaQa8OLFqq3HWpSLFnn0BMsM=; b=YLf9RUC6t0vFpF4P4nnPs4puVmp1fmPwEB5d8P6cq3Z+LfaW9glEA4hRjyOHAngsxY iYNPRMK8vZOHcfqRkHytmb+DT5MjUdOrLXN5Nkh8RZj/wM6RnXLlI09hMkzx8lG7l1Cp V8moiaMK3HFI72zY8BEg4AzFvasxNNJWpE9LjGmZVbPPbpTbew6ie2zP8A0i2GW9ScUA naQEzfeRtgVkOH8xvHFkZpTm9yQ2+X1zPqcX08fQMT+A1ISYMNtHHyr+t6glMvI9j4+G DwOHslLQeygWio7ySTtEtdczxxOtLJ8I16lF+79UTMRAskwdtFQEtdWzBOuEj7flfICc ZRFA== X-Forwarded-Encrypted: i=1; AJvYcCWFSqnth6PBjIsor48/gwGeu6Rxq+SOBYLR5hBAib/JbVunvmqrAruZrD7ET3A9u6/VdB2PCZTXltzv@vger.kernel.org X-Gm-Message-State: AOJu0YzIji2f5NhaeH01fvWpzD8XGBFiHodl8WlDFxaXWYZVof3GMihT HarATq7Npr6aAlURSQMNGFzQy2y1VKQzBLoRSAWEFzzpdaFmpERs+KgeGgkGLa7ajqE= X-Gm-Gg: ASbGncvgQnHEh6Bs3bhPpfKiPjw3ivIH5jZ7GHfJ+1Y29RCxbxn0JefTOGj9QyrTZFw VtIwoyFkQ1DK1z+uEGaME9f/2cYb6sVZae7uvxIuUAN4evOh8LVxvpzoBUizl4Dm/cwW8qMTRjZ iKSOZtuI6MN1nYISXXr3yvL+2WXO4nSZvVeUDAwJO3KpbTME+6Cp1kcsAPSn0t5QYaZjWNrCIPY gModpscVHdPoT7HZvC58EKa/379VFQkdE9eJVYGyq3wZZOawjkxlThDF3SrReV0OhrijLmbxZFW uJeRTjQtotrCi0pC3mPCKjD/grFJRJWJ0h6TMGqt3rFlJQupQyU+Rq7mxskXwpsmdL4fXPZnr5e ko3Ga+mwFmSPeAquO5EjaRrhFZA== X-Google-Smtp-Source: AGHT+IFV7Jhqi3f7BMO1Zhr2G2rdE07bHjsE7MXYjkCsg5wMsHZGyAO9YBqYnRTTTcCErgswHUlrzQ== X-Received: by 2002:a05:6000:22ca:b0:3b7:6804:9362 with SMTP id ffacd0b85a97d-3b768eedffbmr5348368f8f.26.1753350921106; Thu, 24 Jul 2025 02:55:21 -0700 (PDT) Received: from [10.1.1.59] ([80.111.64.44]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4587054c4c7sm13946445e9.12.2025.07.24.02.55.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Jul 2025 02:55:20 -0700 (PDT) Message-ID: <059e02cfed79d51b1efd398822d98eafd4cbf5fb.camel@linaro.org> Subject: Re: [PATCH RFT v3 3/3] ufs: core: delegate the interrupt service routine to a threaded irq handler From: =?ISO-8859-1?Q?Andr=E9?= Draszik To: Bart Van Assche , Neil Armstrong , Alim Akhtar , Avri Altman , "James E.J. Bottomley" , "Martin K. Petersen" Cc: Manivannan Sadhasivam , linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Griffin , Will McVicker , kernel-team@android.com, Tudor Ambarus Date: Thu, 24 Jul 2025 10:55:19 +0100 In-Reply-To: References: <20250407-topic-ufs-use-threaded-irq-v3-0-08bee980f71e@linaro.org> <20250407-topic-ufs-use-threaded-irq-v3-3-08bee980f71e@linaro.org> <1e06161bf49a3a88c4ea2e7a406815be56114c4f.camel@linaro.org> <68631d36-6bb2-4389-99c1-288a63c82779@acm.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.1-1+build1 Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Tue, 2025-07-22 at 10:22 +0100, Andr=C3=A9 Draszik wrote: > On Mon, 2025-07-21 at 08:28 -0700, Bart Van Assche wrote: > > On 7/21/25 5:04 AM, Andr=C3=A9 Draszik wrote: > > > I don't know much about UFS at this stage, but could the code simply > > > check for the controller version and revert to original behaviour > > > if < v4? Any thoughts on such a change? > >=20 > > I'm not sure that's the best possible solution. A more elegant solution > > could be to remove the "if (!hba->mcq_enabled || !hba->mcq_esi_enabled)= " > > check, to restrict the number of commands completed by=20 > > ufshcd_transfer_req_compl() and only to return IRQ_WAKE_THREAD if more > > commands are pending than a certain threshold. >=20 > Thanks Bart. I'll try that instead, I went with a time limit instead of counting the requests in the end, because that should be more deterministic: https://lore.kernel.org/r/20250724-ufshcd-hardirq-v1-1-6398a52f8f02@linaro.= org Cheers, Andre'