From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66DC9C4338F for ; Tue, 10 Aug 2021 06:26:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4B3D36105A for ; Tue, 10 Aug 2021 06:26:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237793AbhHJG0c (ORCPT ); Tue, 10 Aug 2021 02:26:32 -0400 Received: from smtp-out2.suse.de ([195.135.220.29]:51982 "EHLO smtp-out2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234937AbhHJG0b (ORCPT ); Tue, 10 Aug 2021 02:26:31 -0400 Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id D257B2006A; Tue, 10 Aug 2021 06:26:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1628576768; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SnYBioUM58wdgIt/RX3r29M7pdY9HNBq/sS9PilBsLc=; b=xtLyLCymB0y+3eDuyKwC0IAZXKl7KLXtSYUVUc6xTKt5TWTUvxfoVH4X6qP1jeMB7acqcm PwdfmJkUnFihjAkPwIU5GPsns+5Qyx04a4bhNC3xPmhniSTZD4HydscrrJRxYWNuc65NjV hnms/xWd1CbTw3u0+KPcjUHG+LL3giE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1628576768; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SnYBioUM58wdgIt/RX3r29M7pdY9HNBq/sS9PilBsLc=; b=5+g10mE2P/oDKMzPQNh35WOVxpU/Gi5XtbHEjF/bpuCCwg0eyjhk5Kn+4lbiBd87ZpjNHp wKGQaE+xJSqil6BQ== Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id AB122133D0; Tue, 10 Aug 2021 06:26:08 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id KkPvJwAcEmE2PAAAGKfGzw (envelope-from ); Tue, 10 Aug 2021 06:26:08 +0000 Subject: Re: [PATCH v5 16/52] bnx2i: Use scsi_cmd_to_rq() instead of scsi_cmnd.request To: Bart Van Assche , "Martin K . Petersen" Cc: linux-scsi@vger.kernel.org, Nilesh Javali , Manish Rangankar , GR-QLogic-Storage-Upstream@marvell.com, "James E.J. Bottomley" References: <20210809230355.8186-1-bvanassche@acm.org> <20210809230355.8186-17-bvanassche@acm.org> From: Hannes Reinecke Message-ID: <0641ce7a-7e94-c796-e72c-84bfe2fd8ab9@suse.de> Date: Tue, 10 Aug 2021 08:26:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210809230355.8186-17-bvanassche@acm.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org On 8/10/21 1:03 AM, Bart Van Assche wrote: > Prepare for removal of the request pointer by using scsi_cmd_to_rq() > instead. This patch does not change any functionality. > > Signed-off-by: Bart Van Assche > --- > drivers/scsi/bnx2i/bnx2i_hwi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/bnx2i/bnx2i_hwi.c b/drivers/scsi/bnx2i/bnx2i_hwi.c > index 43e8a1dafec0..5521469ce678 100644 > --- a/drivers/scsi/bnx2i/bnx2i_hwi.c > +++ b/drivers/scsi/bnx2i/bnx2i_hwi.c > @@ -1918,7 +1918,7 @@ static int bnx2i_queue_scsi_cmd_resp(struct iscsi_session *session, > > spin_unlock(&session->back_lock); > > - p = &per_cpu(bnx2i_percpu, blk_mq_rq_cpu(sc->request)); > + p = &per_cpu(bnx2i_percpu, blk_mq_rq_cpu(scsi_cmd_to_rq(sc))); > spin_lock(&p->p_work_lock); > if (unlikely(!p->iothread)) { > rc = -EINVAL; > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer