Re: [PATCH v9 12/17] scsi: ufs: mediatek: Rework the code for disabling auto-hibernation

Bao D. Nguyen
2023-08-17T18:41:19Z

On 8/16/2023 12:53 PM, Bart Van Assche wrote:
> Call ufshcd_auto_hibern8_update() instead of writing directly into the
> auto-hibernation control register. This patch is part of an effort to
> move all auto-hibernation register changes into the UFSHCI driver core.
>
> Cc: Martin K. Petersen <martin.petersen@oracle.com>
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
> ---
> drivers/ufs/host/ufs-mediatek.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ufs/host/ufs-mediatek.c b/drivers/ufs/host/ufs-mediatek.c
> index e68b05976f9e..a3cf30e603ca 100644
> --- a/drivers/ufs/host/ufs-mediatek.c
> +++ b/drivers/ufs/host/ufs-mediatek.c
> @@ -1252,7 +1252,7 @@ static void ufs_mtk_auto_hibern8_disable(struct ufs_hba *hba)
> int ret;
>
> /* disable auto-hibern8 */
> - ufshcd_writel(hba, 0, REG_AUTO_HIBERNATE_IDLE_TIMER);
> + ufshcd_auto_hibern8_update(hba, 0);
Since you now use ufshcd_auto_hibern8_update(), the caller should not
need to check for ufshcd_is_auto_hibern8_supported() because this is
already part of the hibern8_update(). Suggest remove the if statement
from the caller.

if (ufshcd_is_auto_hibern8_supported(hba))
ufs_mtk_auto_hibern8_disable(hba);

>
> /* wait host return to idle state when auto-hibern8 off */
> ufs_mtk_wait_idle_state(hba, 5);