Re: [PATCH v9 14/17] scsi: ufs: Rename ufshcd_auto_hibern8_enable() and make it static

Bao D. Nguyen
2023-08-17T21:49:54Z

On 8/17/2023 12:16 PM, Bart Van Assche wrote:
> On 8/17/23 11:49, Bao D. Nguyen wrote:
>> On 8/16/2023 12:53 PM, Bart Van Assche wrote:
>>> -    /* Enable Auto-Hibernate if configured */
>>> -    ufshcd_auto_hibern8_enable(hba);
>>> +    ufshcd_configure_auto_hibern8(hba);
>>
>> Is it possible to have a race between sysfs and syspend/resume trying
>> to update the auto_hibern8?
>
> Only user-space software should write into sysfs. Kernel code should
> not do this. User-space code is paused before the block driver suspend
> callbacks are invoked and resuming block devices completes before
> user space software is resumed. I don't think that sysfs writes can
> race with suspend or resume callbacks.
>Thank you for the explanation.

Thanks
Bao
> Thanks,
>
> Bart.
>