Re: [PATCH v9 14/17] scsi: ufs: Rename ufshcd_auto_hibern8_enable() and make it static

Bart Van Assche
2023-08-17T19:17:03Z

On 8/17/23 11:49, Bao D. Nguyen wrote:
> On 8/16/2023 12:53 PM, Bart Van Assche wrote:
>> -    /* Enable Auto-Hibernate if configured */
>> -    ufshcd_auto_hibern8_enable(hba);
>> +    ufshcd_configure_auto_hibern8(hba);
>
> Is it possible to have a race between sysfs and syspend/resume trying to update the auto_hibern8?

Only user-space software should write into sysfs. Kernel code should
not do this. User-space code is paused before the block driver suspend
callbacks are invoked and resuming block devices completes before
user space software is resumed. I don't think that sysfs writes can
race with suspend or resume callbacks.

Thanks,

Bart.