Re: [PATCH v9 16/17] scsi: ufs: Forbid auto-hibernation without I/O scheduler

Bart Van Assche
2023-08-17T19:19:11Z

On 8/17/23 11:50, Bao D. Nguyen wrote:
> On 8/16/2023 12:53 PM, Bart Van Assche wrote:
>> +/**
>> + * ufshcd_auto_hibern8_update() - Modify the auto-hibernation control register
>> + * @hba: per-adapter instance
>> + * @ahit: New auto-hibernate settings. Includes the scale and the value of the
>> + * auto-hibernation timer. See also the UFSHCI_AHIBERN8_TIMER_MASK and
>> + * UFSHCI_AHIBERN8_SCALE_MASK constants.
>> + *
>> + * Note: enabling auto-hibernation if a zoned logical unit is present without
>> + * attaching the mq-deadline scheduler first to the zoned logical unit may cause
>> + * unaligned write errors for the zoned logical unit.
>> + */
>
> Please improve this "Note:". It seems like a run-on sentence and not very clear.

There are no grammatical errors in that note. Anyway, I will make the note
more clear.

Thanks,

Bart.