From: Bart Van Assche <bvanassche@acm.org>
To: daejun7.park@samsung.com,
"Martin K . Petersen" <martin.petersen@oracle.com>
Cc: Jaegeuk Kim <jaegeuk@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
Can Guo <cang@codeaurora.org>,
Stanley Chu <stanley.chu@mediatek.com>,
Asutosh Das <asutoshd@codeaurora.org>,
James Bottomley <James.Bottomley@HansenPartnership.com>,
Vinayak Holikatti <vinholikatti@gmail.com>,
VISHAK G <vishak.g@samsung.com>,
Girish K S <girish.shivananjappa@linaro.org>,
Santosh Yaraganavi <santoshsy@gmail.com>,
"huobean@gmail.com" <huobean@gmail.com>
Subject: Re: [PATCH] scsi: ufs: Improve SCSI abort handling
Date: Thu, 4 Nov 2021 16:14:42 -0700 [thread overview]
Message-ID: <087fe1fe-173d-50dd-a52e-d794c97648da@acm.org> (raw)
In-Reply-To: <1891546521.01636066202065.JavaMail.epsvc@epcpadp3>
On 11/4/21 3:39 PM, Daejun Park wrote:
> I found similar code in the ufshcd_err_handler(). I think the following
> patch will required to fix another warning.
>
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index f5ba8f953b87..cce9abc6b879 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -6190,6 +6190,7 @@ static void ufshcd_err_handler(struct work_struct *work)
> }
> dev_err(hba->dev, "Aborted tag %d / CDB %#02x\n", tag,
> hba->lrb[tag].cmd ? hba->lrb[tag].cmd->cmnd[0] : -1);
> + hba->lrb[tag].cmd = NULL;
> }
>
> /* Clear pending task management requests */
Hmm ... since the error handler calls ufshcd_complete_requests(),
shouldn't the completion function clear the 'cmd' member? I'm concerned
that the above change would break the completion handler.
Thanks,
Bart.
next prev parent reply other threads:[~2021-11-04 23:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20211104181111epcas2p2965ba25c905be783c39f098210cc4c61@epcms2p2>
2021-11-04 18:10 ` [PATCH] scsi: ufs: Improve SCSI abort handling Bart Van Assche
2021-11-04 22:20 ` Bean Huo
2021-11-04 22:39 ` Daejun Park
2021-11-04 23:14 ` Bart Van Assche [this message]
2021-11-04 23:39 ` Daejun Park
2021-11-04 23:54 ` Bart Van Assche
2021-11-05 1:53 ` Daejun Park
2021-11-07 6:59 ` Stanley Chu
2021-11-09 4:03 ` Martin K. Petersen
2021-11-19 4:16 ` Martin K. Petersen
2021-12-14 16:35 ` James Bottomley
2021-12-14 17:37 ` Bart Van Assche
2021-12-14 17:43 ` James Bottomley
2021-12-14 17:45 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=087fe1fe-173d-50dd-a52e-d794c97648da@acm.org \
--to=bvanassche@acm.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=adrian.hunter@intel.com \
--cc=asutoshd@codeaurora.org \
--cc=cang@codeaurora.org \
--cc=daejun7.park@samsung.com \
--cc=girish.shivananjappa@linaro.org \
--cc=huobean@gmail.com \
--cc=jaegeuk@kernel.org \
--cc=jejb@linux.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=santoshsy@gmail.com \
--cc=stanley.chu@mediatek.com \
--cc=vinholikatti@gmail.com \
--cc=vishak.g@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox