From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A095CDB474 for ; Tue, 17 Oct 2023 20:18:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235060AbjJQUST (ORCPT ); Tue, 17 Oct 2023 16:18:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33082 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235064AbjJQUSI (ORCPT ); Tue, 17 Oct 2023 16:18:08 -0400 Received: from mail-oo1-f42.google.com (mail-oo1-f42.google.com [209.85.161.42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DD0B75BAB; Tue, 17 Oct 2023 13:06:48 -0700 (PDT) Received: by mail-oo1-f42.google.com with SMTP id 006d021491bc7-581e92f615fso345641eaf.2; Tue, 17 Oct 2023 13:06:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697573208; x=1698178008; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=L2Y4eB55Mqf1W00hoGS6DzogP0Qi0j6/+eiOiIBZq2k=; b=hIYbtuFuoWlV+/C2a4KzmlKSq0RaUBEKXLZfAo62wUKrBD2BONGWNuSnxe+RSiD9hP aNKhVxdE3eDi7ajEC9UM50N9iMD34tlTwH0j65aVbdazUzfCO6/jxbpin/G+6oePCu4y Bv+zG4/tvtACLHXw1qJmtw23cNFu5KD4PzvJoygUEUwnRPZeIu+RyMdF9k/6+sRmvd0l RwcttHWDSRPObPBpGOPbiuj829znWMI+E24aq6wy/cb7AQiMThyXI7e3QL5rUyMrF0Wf EdQrVdpn5Ju4f6tD2Bh9pMVRCvOFT5bgcQz+TPVTANSUg3ZOqpMT1BYtqyFXospI4DxA JGHA== X-Gm-Message-State: AOJu0YymQ8LgzFtdHBTxeocNqz/NJYfM0tJpj3JHKe0V8JIVB18Bf54F LCgQFLTuVq/iu3PxEH7OX/I= X-Google-Smtp-Source: AGHT+IGTH10nVUoansKaqdnEFZz8OUzTe9o6C2Y48Q8+QUci4dOfqsDlXB3mp3Hf11PYNEXBa7hE5w== X-Received: by 2002:a05:6358:9da8:b0:135:85ec:a080 with SMTP id d40-20020a0563589da800b0013585eca080mr3552306rwo.32.1697573207945; Tue, 17 Oct 2023 13:06:47 -0700 (PDT) Received: from ?IPV6:2620:15c:211:201:8f02:2919:9600:ac09? ([2620:15c:211:201:8f02:2919:9600:ac09]) by smtp.gmail.com with ESMTPSA id z12-20020aa7948c000000b006b97d5cbb7csm1873852pfk.60.2023.10.17.13.06.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Oct 2023 13:06:47 -0700 (PDT) Message-ID: <08a8d947-25b5-434c-9ba3-282d298b5bfd@acm.org> Date: Tue, 17 Oct 2023 13:06:46 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [bug report] blktests srp/002 hang Content-Language: en-US To: Bob Pearson , Jason Gunthorpe Cc: "Daisuke Matsuda (Fujitsu)" , 'Rain River' , Zhu Yanjun , "leon@kernel.org" , Shinichiro Kawasaki , RDMA mailing list , "linux-scsi@vger.kernel.org" References: <8aff9124-85c0-8e3b-dc35-1017b1540037@gmail.com> <3c84da83-cdbb-3326-b3f0-b2dee5f014e0@linux.dev> <4e7aac82-f006-aaa7-6769-d1c9691a0cec@gmail.com> <29c5de53-cc61-4efc-8e8d-690e27756a16@acm.org> <20231017175821.GG282036@ziepe.ca> <8801fc68-0e8e-4bb1-acaa-597bf72a567d@gmail.com> <20231017185139.GA691768@ziepe.ca> From: Bart Van Assche In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org On 10/17/23 12:55, Bob Pearson wrote: > Well.... the extra tracing did *not* show srp running out of iu's. > So I converted cq handling to IB_POLL_SOFTIRQ from IB_POLL_DIRECT. > This required adding a spinlock around list_add(&iu->list, ...) in > srp_send_done(). The test now runs with all the completions handled > correctly. But, it still hangs. So a red herring. iu->list manipulations are protected by ch->lock. See also the lockdep_assert_held(&ch->lock) statements in the code that does manipulate this list and that does not grab ch->lock directly. Thanks, Bart.