From: Bart Van Assche <bvanassche@acm.org>
To: John Garry <john.g.garry@oracle.com>,
Mike Christie <michael.christie@oracle.com>,
mwilck@suse.com, hch@lst.de, martin.petersen@oracle.com,
linux-scsi@vger.kernel.org,
james.bottomley@hansenpartnership.com
Subject: Re: [PATCH v10 08/33] scsi: Use separate buf for START_STOP in sd_spinup_disk
Date: Wed, 19 Jul 2023 11:41:16 -0700 [thread overview]
Message-ID: <08e146ce-e957-db02-c5b6-8d86e1d30f57@acm.org> (raw)
In-Reply-To: <e040738e-2518-4780-50ef-eb80085ceea4@oracle.com>
On 7/17/23 08:45, John Garry wrote:
>> + /* Return immediately and start spin cycle */
>> + const u8 start_cmd[10] = { START_STOP, 1, 0, 0,
>> + sdkp->device->start_stop_pwr_cond ?
>> + 0x11 : 1 };
>
> same comment as previous patch
I'm not sure that using designated initializers for initializing only the
first five elements will improve readability ...
Thanks,
Bart.
next prev parent reply other threads:[~2023-07-19 18:41 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-14 21:33 [PATCH v10 00/33] scsi: Allow scsi_execute users to control retries Mike Christie
2023-07-14 21:33 ` [PATCH v10 01/33] scsi: Add helper to prep sense during error handling Mike Christie
2023-07-17 15:24 ` John Garry
2023-07-14 21:33 ` [PATCH v10 02/33] scsi: Allow passthrough to override what errors to retry Mike Christie
2023-07-17 16:59 ` Bart Van Assche
2023-07-17 18:30 ` Mike Christie
2023-07-14 21:33 ` [PATCH v10 03/33] scsi: Add scsi_failure field to scsi_exec_args Mike Christie
2023-07-14 21:33 ` [PATCH v10 04/33] scsi: Have scsi-ml retry scsi_probe_lun errors Mike Christie
2023-07-19 18:33 ` Bart Van Assche
2023-07-14 21:33 ` [PATCH v10 05/33] scsi: retry INQUIRY after timeout Mike Christie
2023-07-14 21:33 ` [PATCH v10 06/33] scsi: sd: Fix sshdr use in read_capacity_16 Mike Christie
2023-07-17 15:26 ` John Garry
2023-07-19 18:34 ` Bart Van Assche
2023-07-14 21:33 ` [PATCH v10 07/33] scsi: sd: Have scsi-ml retry read_capacity_16 errors Mike Christie
2023-07-17 15:43 ` John Garry
2023-07-17 18:37 ` Mike Christie
2023-07-19 18:38 ` Bart Van Assche
2023-07-14 21:33 ` [PATCH v10 08/33] scsi: Use separate buf for START_STOP in sd_spinup_disk Mike Christie
2023-07-17 15:45 ` John Garry
2023-07-19 18:41 ` Bart Van Assche [this message]
2023-07-19 18:42 ` Bart Van Assche
2023-07-14 21:33 ` [PATCH v10 09/33] scsi: sd: Fix sshdr use " Mike Christie
2023-07-17 16:06 ` John Garry
2023-07-19 18:47 ` Bart Van Assche
2023-07-14 21:33 ` [PATCH v10 10/33] scsi: Have scsi-ml retry sd_spinup_disk errors Mike Christie
2023-07-19 19:53 ` Bart Van Assche
2023-07-14 21:33 ` [PATCH v10 11/33] scsi: hp_sw: Only access sshdr if res > 0 Mike Christie
2023-07-18 13:13 ` John Garry
2023-07-14 21:33 ` [PATCH v10 12/33] scsi: hp_sw: Have scsi-ml retry scsi_exec_req errors Mike Christie
2023-07-18 13:14 ` John Garry
2023-07-14 21:33 ` [PATCH v10 13/33] scsi: rdac: Fix sshdr use Mike Christie
2023-07-18 13:25 ` John Garry
2023-07-18 15:31 ` Mike Christie
2023-07-19 14:44 ` John Garry
2023-07-22 17:10 ` Mike Christie
2023-07-25 7:59 ` John Garry
2023-07-25 15:22 ` Mike Christie
2023-07-14 21:34 ` [PATCH v10 14/33] scsi: rdac: Have scsi-ml retry send_mode_select errors Mike Christie
2023-07-14 21:34 ` [PATCH v10 15/33] scsi: spi: Fix sshdr use Mike Christie
2023-07-18 16:53 ` John Garry
2023-07-14 21:34 ` [PATCH v10 16/33] scsi: spi: Have scsi-ml retry spi_execute errors Mike Christie
2023-07-19 14:43 ` John Garry
2023-07-14 21:34 ` [PATCH v10 17/33] scsi: sd: Fix sshdr use in sd_suspend_common Mike Christie
2023-07-25 9:59 ` John Garry
2023-07-14 21:34 ` [PATCH v10 18/33] scsi: sd: Have scsi-ml retry sd_sync_cache errors Mike Christie
2023-07-25 10:27 ` John Garry
2023-07-14 21:34 ` [PATCH v10 19/33] scsi: ch: Remove unit_attention Mike Christie
2023-07-25 10:30 ` John Garry
2023-07-14 21:34 ` [PATCH v10 20/33] scsi: ch: Have scsi-ml retry ch_do_scsi errors Mike Christie
2023-07-25 10:33 ` John Garry
2023-07-14 21:34 ` [PATCH v10 21/33] scsi: Have scsi-ml retry scsi_mode_sense UAs Mike Christie
2023-07-25 10:36 ` John Garry
2023-07-27 7:48 ` John Garry
2023-07-14 21:34 ` [PATCH v10 22/33] scsi: sd: Fix scsi_mode_sense caller's sshdr use Mike Christie
2023-07-27 7:57 ` John Garry
2023-07-31 18:14 ` michael.christie
2023-07-14 21:34 ` [PATCH v10 23/33] scsi: Have scsi-ml retry scsi_report_lun_scan errors Mike Christie
2023-07-27 8:00 ` John Garry
2023-07-14 21:34 ` [PATCH v10 24/33] scsi: sd: Have pr commands retry UAs Mike Christie
2023-07-14 21:34 ` [PATCH v10 25/33] scsi: sd: Have scsi-ml retry read_capacity_10 errors Mike Christie
2023-07-14 21:34 ` [PATCH v10 26/33] scsi: ses: Have scsi-ml retry scsi_exec_req errors Mike Christie
2023-07-14 21:34 ` [PATCH v10 27/33] scsi: sr: Have scsi-ml retry get_sectorsize errors Mike Christie
2023-07-14 21:34 ` [PATCH v10 28/33] scsi: ufs: Have scsi-ml retry start stop errors Mike Christie
2023-07-17 17:05 ` Bart Van Assche
2023-07-17 18:29 ` Mike Christie
2023-07-17 19:26 ` Bart Van Assche
2023-07-14 21:34 ` [PATCH v10 29/33] scsi: Fix sshdr use in scsi_test_unit_ready Mike Christie
2023-07-27 8:02 ` John Garry
2023-07-14 21:34 ` [PATCH v10 30/33] scsi: Fix sshdr use in scsi_cdl_enable Mike Christie
2023-07-27 8:03 ` John Garry
2023-07-14 21:34 ` [PATCH v10 31/33] scsi: sd: Fix sshdr use in cache_type_store Mike Christie
2023-07-27 8:04 ` John Garry
2023-07-14 21:34 ` [PATCH v10 32/33] scsi: sr: Fix sshdr use in sr_get_events Mike Christie
2023-07-27 8:06 ` John Garry
2023-07-14 21:34 ` [PATCH v10 33/33] scsi: Add kunit tests for scsi_check_passthrough Mike Christie
2023-07-17 16:21 ` [PATCH v10 00/33] scsi: Allow scsi_execute users to control retries Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08e146ce-e957-db02-c5b6-8d86e1d30f57@acm.org \
--to=bvanassche@acm.org \
--cc=hch@lst.de \
--cc=james.bottomley@hansenpartnership.com \
--cc=john.g.garry@oracle.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=michael.christie@oracle.com \
--cc=mwilck@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox