RE: [PATCH 1/2] scsi: ufs: Add an enum for ufs_trace to check ufs cmd error

["DooHyun Hwang" <dh0421.hwang@samsung.com>]

On 8/29/25 8:15 PM, Bart Van Assche wrote:
> On 4/16/25 7:34 PM, DooHyun Hwang wrote:
> > +	EM(UFS_CMD_ERR,		"req_complete_err")		\
> 
> Does UFS_CMD_ERR stand for "command error" or "completion error"? Please
> make the enum label and the text that is displayed in error messages
> consistent.
> 
> Bart.

UFS_CMD_ERR stands for "completion error".
The enum is converted to a string in the trace log according
to the definition below.

in include/trace/events/ufs.h
#define UFS_CMD_TRACE_STRINGS					\
	EM(UFS_CMD_SEND,	"send_req")			\
	EM(UFS_CMD_COMP,	"complete_rsp")			\
+	EM(UFS_CMD_ERR,		"req_complete_err")		\
	EM(UFS_DEV_COMP,	"dev_complete")			\
	EM(UFS_QUERY_SEND,	"query_send")			\
	EM(UFS_QUERY_COMP,	"query_complete")		\
	EM(UFS_QUERY_ERR,	"query_complete_err")		\
	EM(UFS_TM_SEND,		"tm_send")			\
	EM(UFS_TM_COMP,		"tm_complete")			\
	EMe(UFS_TM_ERR,		"tm_complete_err")

Thank you.
DooHyun Hwang.