Linux SCSI subsystem development
 help / color / mirror / Atom feed
From: John Garry <john.garry@linux.dev>
To: FVMA <fvma@protonmail.com>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Cc: "James.Bottomley@HansenPartnership.com"
	<James.Bottomley@HansenPartnership.com>,
	"martin.petersen@oracle.com" <martin.petersen@oracle.com>
Subject: Re: [RFC PATCH] scsi: mvsas: add suspend/resume support
Date: Mon, 7 Sep 2026 08:12:58 +0100	[thread overview]
Message-ID: <09e0a759-8386-46c8-8379-1d3ae31598cd@linux.dev> (raw)
In-Reply-To: <zoyjysrYCqU3F2-p-3UZRqGS1J1LpdjECnhvTzszKX_E4ze5T6JfviETkHg7yj6vJy_X4RaIUe3GEBH23wKKbUOuKyPm7SUur08jDrWyVdE=@protonmail.com>

On 9/5/26 23:12, FVMA wrote:
> The driver has no PM callbacks. After a system suspend the controller 
> returns with its registers at reset values while the driver state 
> assumes a configured chip, so the first command after resume times out 
> and libsas error handling wedges the host.
> 
> Add dev_pm_ops. On suspend, quiesce libsas with sas_suspend_ha(), mask 
> controller interrupts, drain the IRQ and the tasklet, and cancel pending 
> deferred phy events. On resume, reset the ring indices and the STP 
> register set bookkeeping that chip_init() reinitialises in hardware, run 
> chip_init(), re-enable interrupts, report the attached phys through 
> mvs_scan_start() and hand the host back to libsas with sas_resume_ha().
> 
> Signed-off-by: Francois <fvma@protonmail.com <mailto:fvma@protonmail.com>>
> Assisted-by: Claude:claude-fable-5-1
> ---
> Compile-tested against v7.1.13 and current mainline; not yet exercised
> on hardware (88SE9485). 

What is your motivation in posting this change?

You don't even have access to the relevant HW.


      reply	other threads:[~2026-09-07  7:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-05 22:12 [RFC PATCH] scsi: mvsas: add suspend/resume support FVMA
2026-09-07  7:12 ` John Garry [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=09e0a759-8386-46c8-8379-1d3ae31598cd@linux.dev \
    --to=john.garry@linux.dev \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=fvma@protonmail.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox