From: Bart Van Assche <bvanassche@acm.org>
To: "Bao D. Nguyen" <quic_nguyenb@quicinc.com>,
Arthur Simchaev <Arthur.Simchaev@sandisk.com>,
"quic_cang@quicinc.com" <quic_cang@quicinc.com>,
"quic_nitirawa@quicinc.com" <quic_nitirawa@quicinc.com>,
"avri.altman@wdc.com" <avri.altman@wdc.com>,
"peter.wang@mediatek.com" <peter.wang@mediatek.com>,
"manivannan.sadhasivam@linaro.org"
<manivannan.sadhasivam@linaro.org>,
"minwoo.im@samsung.com" <minwoo.im@samsung.com>,
"adrian.hunter@intel.com" <adrian.hunter@intel.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Bean Huo <beanhuo@micron.com>,
Keoseong Park <keosung.park@samsung.com>,
Ziqi Chen <quic_ziqichen@quicinc.com>,
Al Viro <viro@zeniv.linux.org.uk>,
Gwendal Grignou <gwendal@chromium.org>,
Eric Biggers <ebiggers@google.com>,
open list <linux-kernel@vger.kernel.org>,
"moderated list:ARM/Mediatek SoC support:Keyword:mediatek"
<linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC support:Keyword:mediatek"
<linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH v4 1/1] scsi: ufs: core: add device level exception support
Date: Wed, 26 Mar 2025 06:49:43 -0400 [thread overview]
Message-ID: <0a68d437-5d6a-42aa-ae4e-6f5d89cfcaf3@acm.org> (raw)
In-Reply-To: <c5ab13ec-f650-ea10-5cb8-d6a2ddf1e825@quicinc.com>
On 3/25/25 6:15 PM, Bao D. Nguyen wrote:
> The existing "struct utp_upiu_query_v4_0" probably has a bug in it. It
> does not use the __attribute__((__packed__)) attribute. The compiler is
> free to add padding in this structure, resulting in the read attribute
> value being incorrect. I plan to provide a separate patch to fix this
> issue.
Adding __attribute__((__packed__)) or __packed to data structures that
don't need it is not an improvement but is a change that makes
processing slower on architectures that do not support unaligned
accesses. Instead of adding __packed to data structures in their
entirety, only add it to those members that need it and check the
structure size as follows:
static_assert(sizeof(...) == ...);
Thanks,
Bart.
next prev parent reply other threads:[~2025-03-26 10:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-21 3:18 [PATCH v4 1/1] scsi: ufs: core: add device level exception support Bao D. Nguyen
2025-03-21 16:31 ` Bart Van Assche
2025-03-25 16:33 ` Arthur Simchaev
2025-03-25 22:15 ` Bao D. Nguyen
2025-03-26 7:30 ` Arthur Simchaev
2025-03-26 23:28 ` Bao D. Nguyen
2025-03-26 10:49 ` Bart Van Assche [this message]
2025-03-26 23:47 ` Bao D. Nguyen
2025-03-27 11:36 ` Bart Van Assche
2025-03-27 21:45 ` Bao D. Nguyen
2025-03-28 14:02 ` Bart Van Assche
2025-04-02 7:49 ` manivannan.sadhasivam
2025-04-02 19:00 ` Bao D. Nguyen
2025-04-06 18:23 ` manivannan.sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a68d437-5d6a-42aa-ae4e-6f5d89cfcaf3@acm.org \
--to=bvanassche@acm.org \
--cc=Arthur.Simchaev@sandisk.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=adrian.hunter@intel.com \
--cc=alim.akhtar@samsung.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=ebiggers@google.com \
--cc=gwendal@chromium.org \
--cc=keosung.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=martin.petersen@oracle.com \
--cc=matthias.bgg@gmail.com \
--cc=minwoo.im@samsung.com \
--cc=peter.wang@mediatek.com \
--cc=quic_cang@quicinc.com \
--cc=quic_nguyenb@quicinc.com \
--cc=quic_nitirawa@quicinc.com \
--cc=quic_ziqichen@quicinc.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox