From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC0E8C6FA83 for ; Mon, 26 Sep 2022 10:51:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236703AbiIZKvi (ORCPT ); Mon, 26 Sep 2022 06:51:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37070 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237022AbiIZKu1 (ORCPT ); Mon, 26 Sep 2022 06:50:27 -0400 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8ED1158B5A; Mon, 26 Sep 2022 03:27:21 -0700 (PDT) Received: from fraeml709-chm.china.huawei.com (unknown [172.18.147.201]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4Mbf6k5v0Hz688XS; Mon, 26 Sep 2022 18:26:06 +0800 (CST) Received: from lhrpeml500003.china.huawei.com (7.191.162.67) by fraeml709-chm.china.huawei.com (10.206.15.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 26 Sep 2022 12:27:17 +0200 Received: from [10.48.156.245] (10.48.156.245) by lhrpeml500003.china.huawei.com (7.191.162.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 26 Sep 2022 11:27:17 +0100 Message-ID: <0b9ce76d-4c0d-615d-3345-5803fb29db45@huawei.com> Date: Mon, 26 Sep 2022 11:27:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH v4 0/7] libsas and drivers: NCQ error handling To: "Martin K. Petersen" CC: , , , , , , References: <1663840018-50161-1-git-send-email-john.garry@huawei.com> From: John Garry In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.48.156.245] X-ClientProxiedBy: lhrpeml100003.china.huawei.com (7.191.160.210) To lhrpeml500003.china.huawei.com (7.191.162.67) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org On 25/09/2022 19:02, Martin K. Petersen wrote: Hi Martin, >> Based on mkp-scsi @ 6.1/scsi-staging 7f615c1b5986 ("scsi: >> scsi_transport_fc: Use %u for dev_loss_tmo") > Can you please rebase on top of the latest staging? There are a couple > of pm8001 conflicts. Sorry about that, I did test that it applied ok but I did not test building it again. Anyway, this is the only issue I saw: drivers/scsi/pm8001/pm8001_hwi.c: In function ‘pm8001_mpi_task_abort_resp’: drivers/scsi/pm8001/pm8001_hwi.c:3520:15: error: ‘pm8001_dev’ undeclared (first use in this function); did you mean ‘pm8001_dbg’? 3520 | atomic_dec(&pm8001_dev->running_req); | ^~~~~~~~~~ | pm8001_dbg Was there another issue? Thanks, John