Re: [PATCH v11 26/34] scsi: sd: Have scsi-ml retry read_capacity_10 errors

Martin Wilck
2023-09-15T21:26:27Z

On Tue, 2023-09-05 at 18:15 -0500, Mike Christie wrote:
> This has read_capacity_10 have scsi-ml retry errors instead of
> driving
> them itself.
>
> There are two behavior changes:
> 1. We no longer retry when scsi_execute_cmd returns < 0, but we
> should be
> ok. We don't need to retry for failures like the queue being removed,
> and
> for the case where there are no tags/reqs the block layer
> waits/retries
> for us. For possible memory allocation failures from blk_rq_map_kern
> we
> use GFP_NOIO, so retrying will probably not help.
> 2. For device reset UAs, we would retry
> READ_CAPACITY_RETRIES_ON_RESET
> times, then once those are used up we would hit the main do loops
> retry
> counter and get 3 more retries. We now only get
> READ_CAPACITY_RETRIES_ON_RESET retries.
>
> Signed-off-by: Mike Christie <michael.christie@oracle.com>
> Reviewed-by: Christoph Hellwig <hch@lst.de>

Reviewed-by: Martin Wilck <mwilck@suse.com>