From: Bart Van Assche <bvanassche@acm.org>
To: Andrew Halaney <ahalaney@redhat.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Manivannan Sadhasivam <mani@kernel.org>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Yaniv Gardi <ygardi@codeaurora.org>,
Dov Levenglick <dovl@codeaurora.org>
Cc: Will Deacon <will@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: ufs: qcom: Perform read back after writing reset bit
Date: Mon, 11 Dec 2023 09:59:25 -0800 [thread overview]
Message-ID: <0d59681d-2d7d-4459-b79c-c5f41f20b7a5@acm.org> (raw)
In-Reply-To: <20231208-ufs-reset-ensure-effect-before-delay-v1-1-8a0f82d7a09e@redhat.com>
On 12/8/23 12:19, Andrew Halaney wrote:
> The recommendation for ensuring this bit has taken effect on the
> device is to perform a read back to force it to make it all the way
> to the device. This is documented in device-io.rst [... ]
There are more mb()'s that need to be replaced, namely the mb() calls in
ufshcd_system_restore() and ufshcd_init().
Thanks,
Bart.
next prev parent reply other threads:[~2023-12-11 17:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-08 20:19 [PATCH] scsi: ufs: qcom: Perform read back after writing reset bit Andrew Halaney
2023-12-11 9:36 ` Manivannan Sadhasivam
2023-12-11 17:59 ` Bart Van Assche [this message]
2023-12-11 19:51 ` Andrew Halaney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d59681d-2d7d-4459-b79c-c5f41f20b7a5@acm.org \
--to=bvanassche@acm.org \
--cc=agross@kernel.org \
--cc=ahalaney@redhat.com \
--cc=andersson@kernel.org \
--cc=dovl@codeaurora.org \
--cc=jejb@linux.ibm.com \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mani@kernel.org \
--cc=martin.petersen@oracle.com \
--cc=will@kernel.org \
--cc=ygardi@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox