Re: [PATCH] scsi: isci: initialize shost fully before calling scsi_add_host()

John Garry
2019-01-10T09:11:44Z

On 09/01/2019 18:41, Christoph Hellwig wrote:
> This looks good. I wonder if there is any good way to prevent other
> drivers from picking up this bug byt using a better interface, but
> that should not delay your fix.
>
> .
>

I noticed that hisi_sas has this same problem but I forgot to fix it.

So how about just drop these APIs and let the user set the shost
protection parameters directly, like other shost parameters, which
should make it a bit clearer when these should be set, i.e. before
scsi_add_host()?

John