Linux SCSI subsystem development
 help / color / mirror / Atom feed
From: Tomas Henzl <thenzl@redhat.com>
To: Hannes Reinecke <hare@suse.de>,
	"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>,
	James Bottomley <james.bottomley@hansenpartnership.com>,
	linux-scsi@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
	Hannes Reinecke <hare@suse.com>
Subject: Re: [PATCH] hpsa: fix uninitialized variable
Date: Tue, 22 Nov 2016 17:32:03 +0100	[thread overview]
Message-ID: <0e07702a-eb51-56df-cdbc-c6d661b26f30@redhat.com> (raw)
In-Reply-To: <1479827138-2211-1-git-send-email-hare@suse.de>

On 22.11.2016 16:05, Hannes Reinecke wrote:
> With the recent patch to hpsa this warning is issued:
>
> drivers/scsi/hpsa.c: In function 'hpsa_slave_alloc':
> drivers/scsi/hpsa.c:2033:5: error: 'sd' may be used uninitialized in this function [-Werror=maybe-uninitialized]
>
> The patch that caused this is marked for stable backports,
> so this one has to be backported on top as well.
>
> Fixes: 4eb307f7b18d ("scsi: hpsa: use bus '3' for legacy HBA devices")
>
> Signed-off-by: Hannes Reinecke <hare@suse.com>

Looks good.

Reviewed-by: Tomas Henzl <thenzl@redhat.com>

Tomas


  reply	other threads:[~2016-11-22 16:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-22 15:05 [PATCH] hpsa: fix uninitialized variable Hannes Reinecke
2016-11-22 16:32 ` Tomas Henzl [this message]
2016-11-22 21:09 ` Arnd Bergmann
2016-11-22 21:57 ` Martin K. Petersen
2016-11-23  7:20   ` Hannes Reinecke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0e07702a-eb51-56df-cdbc-c6d661b26f30@redhat.com \
    --to=thenzl@redhat.com \
    --cc=arnd@arndb.de \
    --cc=hare@suse.com \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=james.bottomley@hansenpartnership.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox