RE: [PATCH] scsi: ufs-bsg: Remove ufs_bsg_get_query_desc_size function

Arthur Simchaev
2022-09-28T14:42:18Z

Agree with you. Will change & send the patch.

Regards
Arthur

> -----Original Message-----
> From: Bean Huo <huobean@gmail.com>
> Sent: Wednesday, September 28, 2022 1:36 PM
> To: Arthur Simchaev <Arthur.Simchaev@wdc.com>;
> martin.petersen@oracle.com; beanhuo@micron.com
> Cc: linux-scsi@vger.kernel.org; linux-kernel@vger.kernel.org; Daniil Lunev
> <dlunev@chromium.org>; Avri Altman <Avri.Altman@wdc.com>; Avi
> Shchislowski <Avi.Shchislowski@wdc.com>
> Subject: Re: [PATCH] scsi: ufs-bsg: Remove ufs_bsg_get_query_desc_size
> function
>
> CAUTION: This email originated from outside of Western Digital. Do not click
> on links or open attachments unless you recognize the sender and know that
> the content is safe.
>
>
> On Wed, 2022-09-28 at 08:33 +0000, Arthur Simchaev wrote:
> > Hi Bean
> >
> > In case you don't have any comments I will appreciate if you will add
> > "reviewed by" to the patch.
> >
> > Regards
> > Arthur
>
>
> Hi Arthur,
>
> I'm thinking we should remove the desc size check in ufshcd.c entirely.
> Just read any descriptor with a maximum size of QUERY_DESC_MAX_SIZE .
> For user space queries, ufs_bsg reads data of the maximum length and
> returns the requested length data. Thus can improve code readability
> and save CPU cycles, also can fix your concern.
>
> I don't know how about others' opinion?
>
> Kind regards,
> Bean
>
>