Re: [PATCH] scsi: ufs-bsg: Remove ufs_bsg_get_query_desc_size function

Bean Huo
2022-09-28T10:36:39Z

On Wed, 2022-09-28 at 08:33 +0000, Arthur Simchaev wrote:
> Hi Bean
>
> In case you don't have any comments I will appreciate if you will add
> "reviewed by" to the patch.
>
> Regards
> Arthur

Hi Arthur,

I'm thinking we should remove the desc size check in ufshcd.c entirely.
Just read any descriptor with a maximum size of QUERY_DESC_MAX_SIZE .
For user space queries, ufs_bsg reads data of the maximum length and
returns the requested length data. Thus can improve code readability
and save CPU cycles, also can fix your concern.

I don't know how about others' opinion?

Kind regards,
Bean