From: James Bottomley <James.Bottomley@steeleye.com>
To: linux-scsi@vger.kernel.org
Subject: [PATCH] fix scsi add-single-device
Date: 26 Jan 2003 12:00:58 -0600 [thread overview]
Message-ID: <1043604061.12324.59.camel@mulgrave> (raw)
[-- Attachment #1: Type: text/plain, Size: 142 bytes --]
There was a logic typo in the abstraction of scsi_add_single_device()
that meant it could never work.
The attached patch fixes it.
James
[-- Attachment #2: Type: text/plain, Size: 1102 bytes --]
# This is a BitKeeper generated patch for the following project:
# Project Name: Linux kernel tree
# This patch format is intended for GNU patch command version 2.5 or higher.
# This patch includes the following deltas:
# ChangeSet 1.958 -> 1.959
# drivers/scsi/scsi_scan.c 1.52 -> 1.53
#
# The following is the BitKeeper ChangeSet Log
# --------------------------------------------
# 03/01/26 jejb@mulgrave.(none) 1.959
# [SCSI] make echo scsi add-single-device x x x x > /proc/scsi/scsi work again
#
# Correct the logic error making it fail
# --------------------------------------------
#
diff -Nru a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c
--- a/drivers/scsi/scsi_scan.c Sun Jan 26 11:58:46 2003
+++ b/drivers/scsi/scsi_scan.c Sun Jan 26 11:58:46 2003
@@ -1758,7 +1758,7 @@
shost = scsi_host_hn_get(host);
if (!shost)
return -ENODEV;
- if(scsi_find_device(shost, channel, id, lun) != NULL)
+ if(scsi_find_device(shost, channel, id, lun) == NULL)
goto out;
if (scsi_probe_and_add_lun(shost, NULL, channel, id, lun, NULL) ==
next reply other threads:[~2003-01-26 18:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-26 18:00 James Bottomley [this message]
2003-01-27 8:15 ` [PATCH] fix scsi add-single-device Mike Anderson
2003-01-27 16:07 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1043604061.12324.59.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox