Re: [PATCH] fixes and cleanups for the new command allocation code

Patrick Mansfield
2003-02-05T05:15:16Z

On Tue, Feb 04, 2003 at 07:53:57PM -0600, James Bottomley wrote:
> On Tue, 2003-02-04 at 19:25, Patrick Mansfield wrote:

> But that's not how the block queue works: prep is actually called from
> elv_next_request(). Therefore, if you plug the queue in the request
> function when you're over the queue limit, you only get a single fully
> prepped request waiting in the queue, which, I think, is the desired
> behaviour. Even if the queue is restarted because of I/O pressure, it
> will begin with the prepped request and re-block.

OK that sounds great, except we should not plug the queue since we
have outstanding IO.

> And the slave_{alloc,configure,destroy} needs fixing too.

What is broken?

-- Patrick Mansfield