public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@steeleye.com>
To: alexey@technomagesinc.com
Cc: Christoph Hellwig <hch@infradead.org>,
	SCSI Mailing List <linux-scsi@vger.kernel.org>,
	Jens Axboe <axboe@suse.de>,
	Dennis Gerasimov <denis@technomagesinc.com>,
	viro@math.psu.edu
Subject: Re: hot scsi disk resize
Date: 17 Mar 2003 10:21:41 -0600	[thread overview]
Message-ID: <1047918111.1632.3.camel@mulgrave> (raw)
In-Reply-To: <m365qz8vlp.fsf@lexa.home.net>

On Tue, 2003-03-04 at 01:00, alexey@technomagesinc.com wrote:
> Here is new version of the patch. All procfs-related stuff has been removed.
> One may rescan device size writing something to /sysfs/.../<scsi device>/rescan:

I applied all of this, except this piece:

> diff -uNr linux/fs/block_dev.c edited/fs/block_dev.c
> --- linux/fs/block_dev.c	Mon Jan 20 02:23:49 2003
> +++ edited/fs/block_dev.c	Mon Mar  3 18:49:47 2003
> @@ -623,6 +623,8 @@
>  			up(&whole->bd_sem);
>  		}
>  	} else {
> +		if (!part)
> +			bd_set_size(bdev,(loff_t)get_capacity(disk)<<9);
>  		put_disk(disk);
>  		module_put(owner);
>  		if (bdev->bd_contains == bdev) {
> 
> 

Because adding this in will break the initial ramdisk.  Thus, although
the SCSI layer does resize, the block layer may not.

I've copied Al Viro because he's more familiar with the block layer
device code than I and may have been planning to add this feature.  Al,
can you tell us what needs to happen to allow for hot resizing a SCSI
disc?

Thanks,

James



  reply	other threads:[~2003-03-17 16:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-03-03 17:21 hot scsi disk resize Alex Tomas
2003-03-03 18:15 ` Christoph Hellwig
2003-03-04  5:37   ` Alex Tomas
2003-03-04  7:00   ` alexey
2003-03-17 16:21     ` James Bottomley [this message]
2003-03-17 16:30       ` Christoph Hellwig
2003-03-04  9:31 ` Fabien Salvi
2003-03-04  9:42   ` alexey
2003-03-05 10:18     ` Fabien Salvi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1047918111.1632.3.camel@mulgrave \
    --to=james.bottomley@steeleye.com \
    --cc=alexey@technomagesinc.com \
    --cc=axboe@suse.de \
    --cc=denis@technomagesinc.com \
    --cc=hch@infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=viro@math.psu.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox