* 2.5.x why a conditional call to blkdev_dequeue_request?
@ 2003-04-08 3:40 Patrick Mansfield
2003-04-08 4:13 ` James Bottomley
0 siblings, 1 reply; 2+ messages in thread
From: Patrick Mansfield @ 2003-04-08 3:40 UTC (permalink / raw)
To: linux-scsi
Why do we conditionally call blkdev_dequeue_request, and yet run the same
code even if a request is not dequeued?
Should we always call blkdev_dequeue_request, and handle
blk_queue_start_tag() returning != 0 as a bug or a resource limitation?
In 2.5 scsi_lib.c scsi_request_fn right now we have:
if (!(blk_queue_tagged(q) && (blk_queue_start_tag(q, req) == 0)))
blkdev_dequeue_request(req);
/* then handle the request whether it was dequeued or not */
-- Patrick Mansfield
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: 2.5.x why a conditional call to blkdev_dequeue_request?
2003-04-08 3:40 2.5.x why a conditional call to blkdev_dequeue_request? Patrick Mansfield
@ 2003-04-08 4:13 ` James Bottomley
0 siblings, 0 replies; 2+ messages in thread
From: James Bottomley @ 2003-04-08 4:13 UTC (permalink / raw)
To: Patrick Mansfield; +Cc: SCSI Mailing List
On Mon, 2003-04-07 at 22:40, Patrick Mansfield wrote:
> Why do we conditionally call blkdev_dequeue_request, and yet run the same
> code even if a request is not dequeued?
>
> Should we always call blkdev_dequeue_request, and handle
> blk_queue_start_tag() returning != 0 as a bug or a resource limitation?
>
> In 2.5 scsi_lib.c scsi_request_fn right now we have:
>
> if (!(blk_queue_tagged(q) && (blk_queue_start_tag(q, req) == 0)))
> blkdev_dequeue_request(req);
>
> /* then handle the request whether it was dequeued or not */
>
blk_queue_start_tag dequeues for you. It's for IDE and other block code
where the request is left in the queue while being processed. In SCSI
we dequeue regardless of whether we're tagged or not.
James
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2003-04-08 4:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-04-08 3:40 2.5.x why a conditional call to blkdev_dequeue_request? Patrick Mansfield
2003-04-08 4:13 ` James Bottomley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox