Re: [usb-storage] Re: PATCH: exclude certain commands from emulated SCSI hosts

Matthew Dharm
2003-04-22T15:24:22Z

[-- Attachment #1: Type: text/plain, Size: 1641 bytes --]

On Tue, Apr 22, 2003 at 03:31:52PM +0100, Alan Cox wrote:
> On Maw, 2003-04-22 at 02:17, Matthew Dharm wrote:
> > Your patches went a long way to improving things. But, then people added
> > EVPD and further changed MODE_SENSE and other things. It's pretty clear
> > to me that trying to change the SCSI core to not use these commands isn't
> > going to happen -- so I want a way to filter them. I originally wanted a
> > centralized filter (i.e. usb-storage could indicate to the mid-layer not to
> > send the 'unwelcome' commands), but that got shot down in favor of a
> > centralized filter-framework which could be applied by any LLDD that wanted
> > to.
>
> You already can do this. You just need to write yourself a library
> routine which converts/blocks according to the filter rules (ie
> read6->read10, returns errors to fancy stuff etc).

I thought that the entire point was to have all this in a centralized place
for use by multiple LLDDs (or anyone else for that matter). Which is the
entire point of this discussion.

If it's not going to be accepted as a centralized filter-framework, then
I'll just add it to the usb-storage driver and leave it at that. But I'm
pretty certain that we will keep revisiting this issue as we see more and
more development of the SCSI core to support some more unusual commands and
we see more and more emulated-SCSI busses which choke on those commands.

Matt

--
Matthew Dharm Home: mdharm-usb@one-eyed-alien.net
Maintainer, Linux USB Mass Storage Driver

It was a new hope.
-- Dust Puppy
User Friendly, 12/25/1998

[-- Attachment #2: Type: application/pgp-signature, Size: 232 bytes --]