Re: [example PATCH - not for applying] exclude certain commands

[James Bottomley <James.Bottomley@steeleye.com>]

On Wed, 2003-04-23 at 18:39, Andries.Brouwer@cwi.nl wrote:
> --- protocol.c~ Fri Nov 22 22:40:13 2002
> +++ protocol.c  Thu Apr 24 00:38:31 2003
> @@ -366,6 +366,8 @@
>                         srb->cmnd[2] = srb->cmnd[2];
>                         srb->cmnd[1] = srb->cmnd[1];
>                         srb->cmnd[0] = srb->cmnd[0] | 0x40;
> +                       if (srb->cmnd[8] < 8)
> +                               srb->cmnd[8] = 8;
>                         break;
>                 } /* switch (srb->cmnd[0]) */
>         } /* if (us->flags & US_FL_MODE_XLATE) */
> 
> (yes, ugly, no guarantee that the buffer is large enough).
> 
> Comments?

Yes, the buffer size thing would be my major concern too...except that
the usb layer seems to get away with doing this type of thing all over
the place.

I think I can argue that this type of thing is always safe: DMA buffers
cannot be stack allocated, and kmalloc comes in minimum units of 32
bytes, so it looks like it's ugly but should always work.

James