From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Bottomley Subject: Re: Aic7xxx and Aic79xx Driver Updates Date: 02 May 2003 09:30:35 -0500 Sender: linux-kernel-owner@vger.kernel.org Message-ID: <1051885837.1820.34.camel@mulgrave> References: <1866260000.1051828092@aslan.btc.adaptec.com> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1866260000.1051828092@aslan.btc.adaptec.com> To: "Justin T. Gibbs" Cc: SCSI Mailing List , Linux Kernel , Linus Torvalds , Alan Cox , Marcelo Tosatti List-Id: linux-scsi@vger.kernel.org First off, could you take a look at http://bugzilla.kernel.org/show_bug.cgi?id=608 I thought it was an sr problem, but it doesn't seem to show up on anything other than adaptec controllers? Thanks. On Thu, 2003-05-01 at 17:28, Justin T. Gibbs wrote: > ChangeSet > 1.1118.33.5 03/04/24 15:12:48 gibbs@overdrive.btc.adaptec.com +7 -0 > Aic7xxx and Aic79xx Driver Updates > o Adapt to new IRQ handler declaration/behavior for 2.5.X The changes for this: +#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,5,0) +#define AIC_LINUX_IRQRETURN_T irqreturn_t +#define AIC_LINUX_IRQRETURN(ours) return (IRQ_RETVAL(ours)) +#else +#define AIC_LINUX_IRQRETURN_T void +#define AIC_LINUX_IRQRETURN(ours) return +#endif Are rather convoluted. Could you just remove the wrappering for 2.5? > ChangeSet > 1.971.94.5 03/04/24 11:46:55 gibbs@overdrive.btc.adaptec.com +2 -0 > Aic7xxx and Aic79xx driver updates > o Work around peculiarities in the scan_scsis routines > that could, due to having duplicate devices on our > host's device list, cause tagged queing to be disabled > for devices added via /proc. -ahc_linux_select_queue_depth(struct Scsi_Host * host, - Scsi_Device * scsi_devs) +ahc_linux_select_queue_depth(struct Scsi_Host *host, Scsi_Device *scsi_devs) select_queue_depth isn't a 2.5 interface anymore, why do you even still need it? > ChangeSet > 1.971.94.3 03/04/24 11:24:15 gibbs@overdrive.btc.adaptec.com +6 -0 > Aic7xxx and Aic79xx driver Update > o Avoid pre-2.5.X mid-layer deadlock due to SCSI malloc fragmentation [...] This is entirely irrelevant to 2.5 as well. James