Re: [PATCH] ips 2.5 driver update [1/4] irq return update

[James Bottomley <James.Bottomley@steeleye.com>]

On Tue, 2003-05-06 at 12:34, Jeffery, David wrote:
> This is the proper way to report if the interrupt
> was from a serveraid or not.

This: 

> +   irqreturn_t       irqstatus;
[...]
> +   irqstatus = (*ha->func.intr)(ha);
[...]
> -   return IRQ_HANDLED;
> +   return IRQ_RETVAL(irqstatus);

Doesn't look right.  Either your (ha->func.intr) returns true or false
and you need to put it through IRQ_RETVAL to get the correct IRQ_ value,
or it returns IRQ_HANDLED, IRQ_NONE and you just return these directly
(the latter looks to be what it does, so the IRQ_RETVAL() isn't needed).

I'm not sure this will work on 2.4 kernels, though, because the compiler
will then be making a

void irqstatus;

declaration which I think at least some versions of gcc won't like.

James