From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Bottomley Subject: Re: [patch] NCR5380.c fix Date: 15 May 2003 17:52:06 -0500 Sender: linux-kernel-owner@vger.kernel.org Message-ID: <1053039127.3998.23.camel@mulgrave> References: Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: To: Andries.Brouwer@cwi.nl Cc: Linux Kernel , SCSI Mailing List , torvalds@transmeta.com List-Id: linux-scsi@vger.kernel.org On Thu, 2003-05-15 at 17:45, Andries.Brouwer@cwi.nl wrote: > - else if (cmd->SCp.Status != GOOD) > + else if (status_byte(cmd->SCp.Status) != GOOD) Well...if we're doing it this way, any reason not to use the newly minted SAM_STAT_GOOD and SAM_STAT_CHECK_CONDITION? James