Re: Round II on sysfs attributes

[James Bottomley <James.Bottomley@steeleye.com>]

On Fri, 2003-05-23 at 14:30, Patrick Mansfield wrote:
> On Fri, May 23, 2003 at 12:38:24PM -0400, James Bottomley wrote:
> > 
> > The attached patch makes the sysfs attributes a property of the host
> > template (I can't really see a reason why the actual attributes need to
> > change per host, so I think the template is the better place for them).
> > 
> > I've also provided helper functions to modify the attributes in the LLD
> > init routines.
> > 
> > An illustration of how this works for the 53c700 will follow.
> > 
> > James
> 
> Any examples of potential LLDD specific host attributes?

Certainly things like the firmware SEEPROM loading that aic7xxx does. 
Possibly global (or per host) resource counts for HBA's that have single
issue queue (again, aic7xxx; and even the 53c700 has this).

> Looks good for modifying attributes.
> 
> For additional attributes, why not an LLDD specific function to add and
> remove them?

That would require knowledge of what the "official" host attributes are,
so it seemed to me that leaving it up to the routine to determine
whether it's an addition or an override was more appropriate.  If we
have a separate routine for adds it would have to have an error case for
adding an existing resource...

James