Re: [PATCH] make the SCSI mid-layer obey the device online flag

[James Bottomley <James.Bottomley@steeleye.com>]

On Wed, 2003-06-04 at 20:34, Patrick Mansfield wrote:
> I thought that USB sending a command after online cleared was likely the
> last prepped request being sent. This can't be fixed within scsi_prep_fn,
> since it will not be called for the last request after online is cleared.
> 
> So we might as well move all the checking of online into the
> scsi_request_fn.

Not unless there's agreement that prepared commands need killing.  To do
this in the simple fashion I outlined in the email (with the two
conditions), the prep function is the correct place for the check.

If the check is moved into the request function you have to worry about
freeing the allocated structures and terminating it yourself, which adds
unnecessary complexity.

Since the LLD knows it must handle commands until the slave_destroy, I
don't see a compelling reason to go to extraordinary lengths to prevent
it from seeing them.

James