From: James Bottomley <James.Bottomley@steeleye.com>
To: Christoph Hellwig <hch@lst.de>
Cc: SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] some sd.c code consolidation
Date: 11 Jun 2003 19:06:12 -0500 [thread overview]
Message-ID: <1055376373.3806.6.camel@mulgrave> (raw)
In-Reply-To: <20030609162402.GA1890@lst.de>
[-- Attachment #1: Type: text/plain, Size: 283 bytes --]
On Mon, 2003-06-09 at 11:24, Christoph Hellwig wrote:
> fold sd_init_onedisk into sd_revalidate_disk and sd_synchronize_cache
> into sd_shutdown.
You didn't actually boot this one, did you? There's a use before
initialise of gendisk->private_data in sd_revalidate_disk().
James
[-- Attachment #2: tmp.diff --]
[-- Type: text/plain, Size: 557 bytes --]
===== drivers/scsi/sd.c 1.120 vs edited =====
--- 1.120/drivers/scsi/sd.c Sun Jun 8 15:33:57 2003
+++ edited/drivers/scsi/sd.c Wed Jun 11 18:59:49 2003
@@ -1340,13 +1340,14 @@
strcpy(gd->devfs_name, sdp->devfs_name);
+ gd->private_data = &sdkp->driver;
+
sd_revalidate_disk(gd);
gd->driverfs_dev = &sdp->sdev_driverfs_dev;
gd->flags = GENHD_FL_DRIVERFS;
if (sdp->removable)
gd->flags |= GENHD_FL_REMOVABLE;
- gd->private_data = &sdkp->driver;
gd->queue = sdkp->device->request_queue;
dev_set_drvdata(dev, sdkp);
next prev parent reply other threads:[~2003-06-11 23:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-09 16:24 [PATCH] some sd.c code consolidation Christoph Hellwig
2003-06-12 0:06 ` James Bottomley [this message]
2003-06-12 5:53 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1055376373.3806.6.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=hch@lst.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox