From: James Bottomley <James.Bottomley@steeleye.com>
To: Sachin Sant <sachinp@in.ibm.com>
Cc: SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: [Patch]Status_byte() in drivers/scsi/scsi.h
Date: 20 Jun 2003 07:37:12 -0500 [thread overview]
Message-ID: <1056112633.1804.5.camel@mulgrave> (raw)
In-Reply-To: <3EF2C869.F794F1A6@in.ibm.com>
On Fri, 2003-06-20 at 03:40, Sachin Sant wrote:
>
> According to Dougs comments , here is the patch to include new macros
> for SAM status codes . Patch is in drivers/scsi/scsi.h
>
> +#define sam_status_value(scmd_result) ((scmd_result) & 0x7e)
This is not the correct thing to do. Our problems with the status byte
stem from its evolving meaning. In SCSI-1, it was a bitmap, in SCSI-2 a
value in a bitrange of reserved bits and in SCSI-3 it covers an entire
byte. In SAM-3 all the defined codes have bit zero set to zero, so your
current patch would do no harm for now, but bit zero is no-longer a
reserved bit.
James
next prev parent reply other threads:[~2003-06-20 12:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-19 8:47 Status_byte() in drivers/scsi/scsi.h Sachin Sant
2003-06-19 9:10 ` Douglas Gilbert
2003-06-20 8:40 ` [Patch]Status_byte() " Sachin Sant
2003-06-20 12:37 ` James Bottomley [this message]
2003-06-20 13:52 ` Douglas Gilbert
2003-06-20 14:39 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1056112633.1804.5.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=linux-scsi@vger.kernel.org \
--cc=sachinp@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox