Re: PATCH; make sr.c respect use_10_for_ms

Matthew Dharm
2003-06-21T23:58:50Z

[-- Attachment #1: Type: text/plain, Size: 1088 bytes --]

On Sat, Jun 21, 2003 at 05:07:48PM -0700, Linus Torvalds wrote:
> On Sat, 21 Jun 2003, Matthew Dharm wrote:
> >
> > This patch makes sr.c respect the use_10_for_ms flag.
>
> Ouch.
>
> Is there some SCSI person out there that would be willing to make sr.c
> look a bit more like sd.c in this respect? This is a bit hacky, I think,
> but I guess the sr.c layout forces that..

I actually think sd.c looks hacky in the way it handles this...

The other difference is that sd.c wants to issue MODE_SENSE in a couple of
places, where sr.c only wants to do it once. So, creating an entirely
separate function to figure out what type of MODE_SENSE to send seems kinda
overkill to me.

I mean, this works, it's not difficult to follow, and meets all the
operational goals.

Matt

--
Matthew Dharm Home: mdharm-usb@one-eyed-alien.net
Maintainer, Linux USB Mass Storage Driver

G: Money isn't everything, A.J.
AJ: Who convinced you of that?
G: The Chief, at my last salary review.
-- Mike and Greg
User Friendly, 11/3/1998