Re: PATCH; make sr.c respect use_10_for_ms

James Bottomley
2003-06-22T13:44:05Z

On Sat, 2003-06-21 at 23:24, Matthew Dharm wrote:
> On Sat, Jun 21, 2003 at 09:54:46PM -0500, James Bottomley wrote:
> > }
> > - n = buffer[3] + 4;
> > + n = rc;
> > cd->cdi.speed = ((buffer[n + 8] << 8) + buffer[n + 9]) / 176;
>
> This bit isn't right. n is supposed to point to the start of the page
> data, not the page header. The header is a different size if the command
> is 6-byte or 10-byte.

Yes it is.

That's why I eliminated the dbd bit. Your patch was calculating the
offsets past the dbd headers. However, if you tell the mode sense not
to send any dbd headers (which are pointless, because the routine isn't
interested in them), then you don't have to skip past them. and the mode
data begins just past the mode header.

James