Re: PATCH; make sr.c respect use_10_for_ms

Matthew Dharm
2003-06-22T00:32:10Z

[-- Attachment #1: Type: text/plain, Size: 1094 bytes --]

On Sat, Jun 21, 2003 at 05:38:44PM -0700, Linus Torvalds wrote:
> The basic idea stands, though: your code depends on global device state
> not to change between the creation of the command and the parsing of it.
> Which just isn't a good thing to do.
>
> sd.c gets all of these things right (including re-transmission etc),
> simply because of how it does things. Which is why I prefer the sd.c
> approach over the simplistic patch. sd.c just looks a lot more robust.
>
> (Maybe that one has bugs too, but they aren't immediately obvious).

Okay, I can buy this. I don't suppose you have someone you can sign-up to
fix this mess? I really want to get rid of all the mode-sense translation
code in usb-storage.

I'm just not qualified to put in what it's going to take to fix this.

Matt

--
Matthew Dharm Home: mdharm-usb@one-eyed-alien.net
Maintainer, Linux USB Mass Storage Driver

Now payink attention, please. This is mouse. Click-click. Easy to
use, da? Now you try...
-- Pitr to Miranda
User Friendly, 10/11/1998