Re: [PATCH] 2.5.73 add mode sense 10 byte to aacraid driver

Jeff Garzik
2003-06-25T18:01:58Z

On Wed, Jun 25, 2003 at 10:21:00AM -0700, Mark Haverkamp wrote:
> The aacraid driver didn't have a case for the 10 byte mode sense
> command. This was causing the driver to fail. I added a case in
> aac_scsi_cmd for the 10 byte mode sense. I also replaced the aacraid
> definitions for scsi commands with the ones from scsi.h. I have tested
> this on my aacraid hardware here at osdl.
>
> ===== drivers/scsi/aacraid/aachba.c 1.17 vs edited =====
> --- 1.17/drivers/scsi/aacraid/aachba.c Thu Jun 19 17:06:21 2003
> +++ edited/drivers/scsi/aacraid/aachba.c Wed Jun 25 08:24:48 2003

In addition to James's comments...

Please separate the cleanup (private -> scsi.h constants)
from the MODE SENSE 10 stuff, into two separate patches.

That way we can apply the cleanup, while discussioning the other stuff.

Jeff