From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Rusty Trivial Russell <rusty@rustcorp.com.au>
Cc: Marcelo Tosatti <marcelo@conectiva.com.br>,
linux-scsi@vger.kernel.org, rmk@arm.linux.org.uk
Subject: Re: [TRIVIAL] 16) request_region check, 11-20
Date: 27 Jun 2003 13:53:08 +0100 [thread overview]
Message-ID: <1056718387.3174.40.camel@dhcp22.swansea.linux.org.uk> (raw)
In-Reply-To: <20030623070136.1F08D2C2E7@lists.samba.org>
On Llu, 2003-06-23 at 08:00, Rusty Trivial Russell wrote:
> --- trivial-2.4.22-pre1/drivers/acorn/scsi/oak.c.orig 2003-06-23 16:39:46.000000000 +1000
> +++ trivial-2.4.22-pre1/drivers/acorn/scsi/oak.c 2003-06-23 16:39:46.000000000 +1000
> @@ -134,7 +134,8 @@
> ecard_claim(ecs[count]);
>
> instance->n_io_port = 255;
> - request_region (instance->io_port, instance->n_io_port, "Oak SCSI");
> + if (!request_region (instance->io_port, instance->n_io_port, "Oak SCSI"))
> + break;
>
Doesn't clean up the register etc - so clearly wrong. Actually I suspect
what needs doing is to request_region first, then register then _check_
the scsi_register return (it doesnt) and unregister the region.
next prev parent reply other threads:[~2003-06-27 12:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-23 7:00 [TRIVIAL] 16) request_region check, 11-20 Rusty Trivial Russell
2003-06-27 12:53 ` Alan Cox [this message]
-- strict thread matches above, loose matches on Subject: below --
2003-02-06 3:22 Rusty Trivial Russell
2002-12-16 10:49 Rusty Trivial Russell
2002-08-07 4:23 Rusty Trivial Russell
2002-08-07 11:33 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1056718387.3174.40.camel@dhcp22.swansea.linux.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=linux-scsi@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
--cc=rmk@arm.linux.org.uk \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox