Re: [PATCH] as i/o hang with aacraid driver 2.6.0-test1

Nick Piggin
2003-07-18T05:20:41Z

Nick Piggin wrote:

>
>
> Andrew Morton wrote:
>
>> Nick Piggin <piggin@cyberone.com.au> wrote:
>>
>>>
>>> Oh, so the request should go on the dispatch list?
>>> OK that makes sense. Maybe also set arq->state = AS_RQ_DISPATCHED
>>> just in case.
>>>
>>> And I think the arq == NULL case should be checked for with
>>> rq->flags & REQ_HARDBARRIER || !blk_fs_request(rq) for consistency.
>>> I think if arq is still NULL then its a bug.
>>>
>>
>> Guys, it's been three days and I'm getting a dribble of sad little
>> messages
>> from various people whose boxes are stuck with everything in D state.
>>
>> Can we please get this thing wrapped up within the next 12 hours so we
>> don't spend all of next week with Linus's tree in such a blatantly buggy
>> state?
>>
>
> No, I think Mark's last patch with Daniel's and my suggestions
> should be fine. It fixes their problems. Its unfortunate that
> this bug never got caught until now but it was inevitable to be
> one or two there.
>
> I have been pretty worried about all the D state messages, but
> between this and the ReiserFS bug, I _think_ they have been
> found. If not, please forward me the reports because I haven't
> seen them. Thanks.
>

Andrew send the one line quick fix in to Linus if you like
until the complete fix is sorted out.