Re: [PATCH] as i/o hang with aacraid driver 2.6.0-test1

Andrew Morton
2003-07-17T23:53:34Z

Daniel McNeil <daniel@osdl.org> wrote:
>
> Should
> list_add(&rq->queuelist, ad->dispatch->prev);
> be
> list_add_tail(&rq->queuelist, ad->dispatch);
>
> It is equivalent, but makes the code clearer that we're adding to the
> end.

yup.

> Also, isn't the: !list_empty(ad->dispatch) unnecessary since a
> list_add was just done, so the list cannot be empty?

more yup.