From: James Bottomley <James.Bottomley@steeleye.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Matthew Dharm <mdharm-usb@one-eyed-alien.net>,
SCSI development list <linux-scsi@vger.kernel.org>
Subject: Re: Comments about the __scsi_mode_sense() routine
Date: 17 Jul 2003 11:47:52 -0400 [thread overview]
Message-ID: <1058456873.2647.55.camel@mulgrave> (raw)
In-Reply-To: <Pine.LNX.4.44L0.0307171037470.750-100000@ida.rowland.org>
On Thu, 2003-07-17 at 10:50, Alan Stern wrote:
> James:
>
> I've got some comments about your __scsi_mode_sense() routine in
> scsi_lib.c. Some of these may be wrong, and I'd like to get the straight
> story.
>
> 1. The kerneldoc at the start describes the return value wrongly.
> The actual return value is the request's result code; it has nothing to do
> with header offsets.
Yes, changed the return convention but not the docbook.
> 2. According to my outdated SCSI documentation, the DBD bit
> should be set to 0 to allow block descriptors and 1 to forbid them. This
> is contrary to the kerneldoc and also contrary to the use in
> sd_read_cache_type() in sd.c.
This was commented on a while ago. Looks like I updated the docbook for
one routine but not the other.
James
next prev parent reply other threads:[~2003-07-17 15:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-22 16:09 Is it safe to do DMA directly into scmd->sense_buffer? Alan Stern
2003-06-22 17:06 ` James Bottomley
2003-07-17 14:50 ` Comments about the __scsi_mode_sense() routine Alan Stern
2003-07-17 15:47 ` James Bottomley [this message]
2003-07-17 19:51 ` Alan Stern
2003-07-30 20:36 ` PATCH: (as73) Do a minimal transfer for disk-cache mode-sense page Alan Stern
2003-07-30 21:04 ` James Bottomley
2003-07-31 15:12 ` Revised PATCH: (as73b) " Alan Stern
2003-07-31 19:53 ` PATCH: (as70b) Update request_bufflen to match this_count Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1058456873.2647.55.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=linux-scsi@vger.kernel.org \
--cc=mdharm-usb@one-eyed-alien.net \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox