Re: [PATCH] as i/o hang with aacraid driver 2.6.0-test1

[James Bottomley <James.Bottomley@steeleye.com>]

On Fri, 2003-07-18 at 11:28, Mark Haverkamp wrote:
> I thought more about what you were saying about checking arq == NULL so
> I have enclosed a patch (compilation of everything) which works for us
> here on our hardware.  I have created file systems on multiple disks,
> did copies and also writes to a raw device as well and have had no
> problems yet.

This one still hangs for me a few I/O operations after my test harness
throws its first device busy.

This:

> +	if (arq) 
> +		if (arq->io_context && arq->io_context->aic) {
> +			arq->state = AS_RQ_DISPATCHED;
> +			atomic_inc(&arq->io_context->aic->nr_dispatched);
> +		}
> +	else
> +		WARN_ON(!(rq->flags & REQ_HARDBARRIER) && blk_fs_request(rq));

Needs braces around the first if otherwise gcc may get where the else
belongs wrong.

James