From: James Bottomley <James.Bottomley@steeleye.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Jens Axboe <axboe@suse.de>,
SCSI development list <linux-scsi@vger.kernel.org>
Subject: Re: Retry scsi_mode_sense if UNIT ATTENTION occurs
Date: 29 Jul 2003 19:23:13 -0400 [thread overview]
Message-ID: <1059520994.2298.263.camel@mulgrave> (raw)
In-Reply-To: <Pine.LNX.4.44L0.0307281005590.797-100000@ida.rowland.org>
On Mon, 2003-07-28 at 10:10, Alan Stern wrote:
> Jens:
>
> This patch changes the scsi_mode_sense() routine to retry up to a total of
> 3 times if a command fails with a UNIT ATTENTION sense key value.
>
> Without this change, sr.c does not properly read the capabilities mode
> page for a just-powered-up cdrom drive -- it gives up upon receiving a
> Device Reset Occurred code.
>
> The patch looks lengthy, but most of it just changes the indentation
> level.
Actually, this isn't really the correct place for it. The problem
occurs in sr not sd because sd already does an initial TUR to clear the
unit attention.
Before OLS got in the way and I got submerged in writing presentations,
I had some patches that Matt Dharm was testing out to add the TUR to the
initial sr code.
I'll pick that up (...er, when I get caught back up at work).
James
next prev parent reply other threads:[~2003-07-29 23:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-24 15:12 Maximum_transfer_size and SCSI request buffer size parameters Alan Stern
2003-07-24 15:35 ` Jens Axboe
2003-07-24 16:22 ` Alan Stern
2003-07-24 19:50 ` PATCH: (as70) " Alan Stern
2003-07-28 14:10 ` Retry scsi_mode_sense if UNIT ATTENTION occurs Alan Stern
2003-07-28 15:08 ` Jeff Garzik
2003-07-28 15:31 ` Alan Stern
2003-07-29 20:28 ` Kai Makisara
2003-07-29 21:10 ` Alan Stern
2003-07-29 23:23 ` James Bottomley [this message]
2003-07-30 14:09 ` Alan Stern
2003-07-30 19:10 ` Matthew Dharm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1059520994.2298.263.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=axboe@suse.de \
--cc=linux-scsi@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox