PATCH: (as84) Fix a mistake in scsi_proc.c

PATCH: (as84) Fix a mistake in scsi_proc.c

[Alan Stern]

James:

I tried sending this patch to Mike Anderson a couple of times, but never
got any response.  It's an obvious fix for a mistake in a section of code
I sent to him last spring: an error path fails to release a mutex.

If you don't see anything wrong here, please apply it.

Alan Stern


===== scsi_proc.c 1.16 vs edited =====
--- 1.16/drivers/scsi/scsi_proc.c	Thu Aug 14 18:37:32 2003
+++ edited/drivers/scsi/scsi_proc.c	Fri Aug 15 15:40:28 2003
@@ -85,12 +85,11 @@
 	down(&global_host_template_sem);
 	if (!sht->present++) {
 		sht->proc_dir = proc_mkdir(sht->proc_name, proc_scsi);
-        	if (!sht->proc_dir) {
+        	if (!sht->proc_dir)
 			printk(KERN_ERR "%s: proc_mkdir failed for %s\n",
 			       __FUNCTION__, sht->proc_name);
-			return;
-		}
-		sht->proc_dir->owner = sht->module;
+		else
+			sht->proc_dir->owner = sht->module;
 	}
 	up(&global_host_template_sem);
 }

Re: PATCH: (as84) Fix a mistake in scsi_proc.c

[James Bottomley]

On Fri, 2003-09-26 at 11:03, Alan Stern wrote:
> I tried sending this patch to Mike Anderson a couple of times, but never
> got any response.  It's an obvious fix for a mistake in a section of code
> I sent to him last spring: an error path fails to release a mutex.
> 
> If you don't see anything wrong here, please apply it.

It's already in the scsi-misc-2.5 BK tree

http://linux-scsi.bkbits.net:8080/scsi-misc-2.5/cset@1.1239.1.2?nav=index.html|ChangeSet@-1d

James

Re: PATCH: (as84) Fix a mistake in scsi_proc.c

[Alan Stern]

On 26 Sep 2003, James Bottomley wrote:

> On Fri, 2003-09-26 at 11:03, Alan Stern wrote:
> > I tried sending this patch to Mike Anderson a couple of times, but never
> > got any response.  It's an obvious fix for a mistake in a section of code
> > I sent to him last spring: an error path fails to release a mutex.
> > 
> > If you don't see anything wrong here, please apply it.
> 
> It's already in the scsi-misc-2.5 BK tree
> 
> http://linux-scsi.bkbits.net:8080/scsi-misc-2.5/cset@1.1239.1.2?nav=index.html|ChangeSet@-1d

Oh, okay -- thanks.  I've just been looking at Linus's tree, which doesn't
have it yet.  But it seems safe to assume it will percolate up there at
some point soon.

Alan Stern