From: James Bottomley <James.Bottomley@steeleye.com>
To: Matthew Wilcox <willy@debian.org>
Cc: Ryan Bradetich <rbradetich@uswest.net>,
SCSI Mailing List <linux-scsi@vger.kernel.org>,
PARISC list <parisc-linux@lists.parisc-linux.org>
Subject: Re: zalon/ncr53c720 crashes K460 (parisc port) on bootup.
Date: 27 Sep 2003 13:58:06 -0500 [thread overview]
Message-ID: <1064689088.2002.188.camel@mulgrave> (raw)
In-Reply-To: <20030927183756.GT24824@parcelfarce.linux.theplanet.co.uk>
On Sat, 2003-09-27 at 13:37, Matthew Wilcox wrote:
> On Sat, Sep 27, 2003 at 10:45:50AM -0500, James Bottomley wrote:
> > This should fix the panic, but it simply detaches correctly.
>
> We both missed it. This is why it's panicing:
>
> host = ncr_attach(&zalon7xx_template, unit, &device);
> if (!host)
> goto fail;
> fail:
> ncr53c8xx_release(host);
> return error;
>
> ie we're calling ncr53c8xx_release(NULL) so both your & my patch fail
> to fix the problem. This looks best to me:
No, I fixed that...that was changed to goto out; in my patch, and out
was just before the return (i.e. no longer do the release).
James
next prev parent reply other threads:[~2003-09-27 18:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-27 3:43 zalon/ncr53c720 crashes K460 (parisc port) on bootup Ryan Bradetich
2003-09-27 7:48 ` [parisc-linux] " Matthew Wilcox
2003-09-27 13:45 ` James Bottomley
2003-09-27 15:45 ` James Bottomley
2003-09-27 17:23 ` Matthew Wilcox
2003-09-27 18:37 ` Matthew Wilcox
2003-09-27 18:43 ` Christoph Hellwig
2003-09-27 18:58 ` James Bottomley [this message]
2003-09-27 20:06 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1064689088.2002.188.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=linux-scsi@vger.kernel.org \
--cc=parisc-linux@lists.parisc-linux.org \
--cc=rbradetich@uswest.net \
--cc=willy@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox