Re: [PATCH] sym53c8xx PPR negotiation fix

James Bottomley
2003-11-01T00:02:25Z

On Fri, 2003-10-31 at 17:55, Justin T. Gibbs wrote:
> BTW, slave_destroy() doesn't seem to be called after a probe
> for a target fails due to a selection timeout. Is this the
> expected behavior? I only keep persistent allocations after
> slave_configure() is called, so this doesn't affect my drivers,
> but the behavior isn't what I expected. This is 2.6.0-test9.

Yes.

slave_configure is only called if the mid-layer decides there's
something worth attaching to there (i.e. if the initial inquiry
succeeds); otherwise it just calls slave_destroy to signal loss of
interest in the target.

The idea is that slave_alloc informs the driver that a probe will be
tried; slave_configure tells the driver we like what we found, we've
initialised the inquiry variables in the target, now negotiate with it.

James