Re: [PATCH] [v2] aha152x cmnd->device oops

Randy.Dunlap
2003-10-28T22:55:06Z

On Tue, 28 Oct 2003 14:50:28 -0800 Mike Christie <mikenc@us.ibm.com> wrote:

| Hi Randy,
|
| > if(!(DONE_SC->SCp.Status & not_issued)) {
| > - Scsi_Cmnd *cmnd = kmalloc(sizeof(Scsi_Cmnd), GFP_ATOMIC);
| > + Scsi_Cmnd *cmnd = scsi_get_command(DONE_SC->device, GFP_ATOMIC);
|
| Do you need to add a scsi_put_command to balance this get when the
| command completes?

Yes, if it continues to use scsi_get_command(). However, I'm
working on an alternate patch now.

| > + cmnd->device = ptr->device;
|
| Don't even need this now. scsi_get_command will set the device for you.

Oh, of course. device was passed to it.

Thanks.

--
~Randy