Re: [PATCH] [v2] aha152x cmnd->device oops

Mike Christie
2003-10-28T22:50:53Z

Hi Randy,

> if(!(DONE_SC->SCp.Status & not_issued)) {
> - Scsi_Cmnd *cmnd = kmalloc(sizeof(Scsi_Cmnd), GFP_ATOMIC);
> + Scsi_Cmnd *cmnd = scsi_get_command(DONE_SC->device, GFP_ATOMIC);

Do you need to add a scsi_put_command to balance this get when the
command completes?

> + cmnd->device = ptr->device;

Don't even need this now. scsi_get_command will set the device for you.

Mike