Re: [PATCH] [v2] aha152x cmnd->device oops

Christoph Hellwig
2003-10-29T13:43:00Z

On Tue, Oct 28, 2003 at 12:45:36PM -0800, Randy.Dunlap wrote:
> if(!(DONE_SC->SCp.Status & not_issued)) {

Strange variable name..

> + cmnd->device = ptr->device;
> cmnd->device->host = ptr->device->host;
> cmnd->device->id = ptr->device->id;
> cmnd->device->lun = ptr->device->lun;

You shouldn't touch either of these.

> - if(cmnd)
> - kfree(cmnd);

You need a scsi_put_command here.