From: James Bottomley <James.Bottomley@steeleye.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: SCSI Mailing List <linux-scsi@vger.kernel.org>,
Mike Anderson <andmike@us.ibm.com>
Subject: Re: [PATCH] correct module refcounting
Date: 31 Oct 2003 09:00:35 -0600 [thread overview]
Message-ID: <1067612438.1782.11.camel@mulgrave> (raw)
In-Reply-To: <20031031121841.A16828@infradead.org>
On Fri, 2003-10-31 at 06:18, Christoph Hellwig wrote:
> That would mean we can't rmmod a LLDD without first removing all device
> through sysfs, or did I get it completely wrong?
Yes, I was thinking the wrong way around. I think we need to use the
scsi_get_device() scsi_put_device() to hold a reference to struct
scsi_device in more places than just ULD open/close. However, obviously
we only need a reference to the module when it shouldn't be removed.
Perhaps all that's really necessary is something like splitting
scsi_device_get() into an __ version that does everything but the module
get. Then we can use the __scsi_device_get() in the critical sections.
James
prev parent reply other threads:[~2003-10-31 15:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-28 21:46 [PATCH] correct module refcounting James Bottomley
2003-10-29 0:17 ` Mike Anderson
2003-10-29 0:42 ` James Bottomley
2003-10-29 1:46 ` Mike Anderson
2003-10-31 12:18 ` Christoph Hellwig
2003-10-31 15:00 ` James Bottomley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1067612438.1782.11.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=andmike@us.ibm.com \
--cc=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox