From: Pat LaVarre <p.lavarre@ieee.org>
To: linux-scsi@vger.kernel.org
Subject: Re: [PATCH] sr cd->device->writeable without purpose
Date: 07 Nov 2003 15:17:09 -0700 [thread overview]
Message-ID: <1068243429.7669.9.camel@patrh9> (raw)
In-Reply-To: <1068163343.2285.55.camel@patrh9>
Kindly offline I hear:
> I think the sr cd->device->writeable bit becomes vestigial - has no
> remaining purpose - once we branch on CDC_MMC_WR instead of
> cd->device->writeable to decide to pass thru or reject writes.
That might or might not be true. However,
> This patch differs from that simpler CDC_MMC_WR patch by updating sr
> cd->device->writeable bit whenever cdrom corrects the sr guess of
> CDC_MMC_WR via op x46 GPCMD_GET_CONFIGURATION.
Ouch, rather silly of me. In that patch, me the newbie, I foolishly:
a) grew cdrom_device_ops to call back into sr ...
b) just before cdrom_get_configuration returns to cdrom_get_cdc, ...
c) just before cdrom_get_cdc returns to register_cdrom, ...
d) just before register_cdrom returns to sr.sr_probe.
That is, I can run the same sr code at almost precisely the same time if
only I place that code immediately after the call to register_cdrom in
sr.sr_probe.
D'oh.
Pat LaVarre
prev parent reply other threads:[~2003-11-07 22:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-11-07 0:02 [PATCH] sr cd->device->writeable without purpose Pat LaVarre
2003-11-07 22:17 ` Pat LaVarre [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1068243429.7669.9.camel@patrh9 \
--to=p.lavarre@ieee.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox