Re: [PATCH] fix Sony USB mass storage - pass larger receive buffer

Patrick Mansfield
2003-11-13T00:44:57Z

On Wed, Nov 12, 2003 at 04:13:10PM -0800, Patrick Mansfield wrote:
> On Wed, Nov 12, 2003 at 04:09:21PM -0800, Matthew Dharm wrote:
> > On Wed, Nov 12, 2003 at 03:50:29PM -0800, Patrick Mansfield wrote:
> > > James - can you please apply? This should not affect other devices since
> > > we are not changing the requested length, just the size of the receive
> > > buffer.
> >
> > This is a terrible idea.
> >
> > There is a large number of devices which choke if those two values do not
> > match.
>
> This is what we do in 2.4 - does USB fix it up for 2.4?
>
> Oh well.

I think see the 2.4 fixups - it looks like it sets the buffer cmd_len to
12, but is (for usb_stor_ufi_command?) setting MODE SENSE 10 to a 8 byte
length (cmd[8] = 8).

Can we use a minium buffer length of 12 for any requests of less than 13
bytes?

Else, I give up on any other methods, and we should add them to the static
black list as BLIST_MS_SKIP_PAGE_3F (skip_ms_page_3f) and probably
BLIST_MS_SKIP_PAGE_08 just to be safe.

-- Patrick Mansfield