Re: [usb-storage] Re: [PATCH] fix Sony USB mass storage - pass larger receive buffer

Matthew Dharm
2003-11-14T02:08:46Z

[-- Attachment #1: Type: text/plain, Size: 1312 bytes --]

On Thu, Nov 13, 2003 at 06:54:16PM -0700, Pat LaVarre wrote:
> > From: Matthew Dharm ...
> > ... I think we're basically at a point where
> > the only problematic command is MODE_SENSE and
> > MODE_SENSE_10, so I say blacklisting them from
> > USB devices should be fine.
>
> Lost me sorry help?
>
> If we eat those commands, how then can write-protect work in Linux for
> that rare case of an actually compliant device with a write-protectab;e
> disk (like the device firmware I remember shipping myself 1994..2003)?

Presumeably, when the send a WRITE command to the device, it will refuse
with meaningful sense data.

> > > If we check after the open for a write failure
> > > to read only media, we cannot keep the same
> > > open semantics (return EROFS on open).
>
> Without mode sense, we will see the open for write pass thru, and we
> will have to teach the fs (ext3, fat, fat32, udf, ...) to recover
> gracefully from a late write error, yes?

This should already be in place.

Matt

--
Matthew Dharm Home: mdharm-usb@one-eyed-alien.net
Maintainer, Linux USB Mass Storage Driver

We've made a business out of making money from annoying and stupid people.
I think you fall under that category.
-- Chief
User Friendly, 7/11/1998

[-- Attachment #2: Type: application/pgp-signature, Size: 232 bytes --]