Re: [usb-storage] Re: [PATCH] fix Sony USB mass storage - pass larger receive buffer

Matthew Dharm
2003-11-14T01:13:06Z

[-- Attachment #1: Type: text/plain, Size: 1175 bytes --]

On Fri, Nov 14, 2003 at 11:13:16AM +1100, Dmitri Katchalov wrote:
> IMHO the solution is either or both of:
> * Blacklist it
> * Define an absolute bare minimum safe subset of SCSI commands and
> fall back to it whenever you see a non-compliant device like this one.

How about:
* Define an absolute bare minimum safe subset of SCSI commands and
use only those commands when communicating with a USB device.

Really, this is just a varient of blacklisting, but it's one I like. I
suggested something like this a while ago -- if the emulated flag was set,
certain commands were not sent. Linus didn't like that, but I think he
objected more to the 'emulated' flag than anything else.

Tho, I think we're basically at a point where the only problematic command
is MODE_SENSE and MODE_SENSE_10, so I say blacklisting them from USB
devices should be fine.

Matt

--
Matthew Dharm Home: mdharm-usb@one-eyed-alien.net
Maintainer, Linux USB Mass Storage Driver

G: Money isn't everything, A.J.
AJ: Who convinced you of that?
G: The Chief, at my last salary review.
-- Mike and Greg
User Friendly, 11/3/1998

[-- Attachment #2: Type: application/pgp-signature, Size: 232 bytes --]