From: James Bottomley <James.Bottomley@steeleye.com>
To: Amit Patel <patelamitv@yahoo.com>
Cc: SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: State Model for scsi device badness PATCH
Date: 20 Nov 2003 13:02:57 -0600 [thread overview]
Message-ID: <1069354978.1770.221.camel@mulgrave> (raw)
In-Reply-To: <20031120190105.7456.qmail@web13007.mail.yahoo.com>
On Thu, 2003-11-20 at 13:01, Amit Patel wrote:
> I just walked through some of the code and I could
> work around the badness problem by not doing
> get_device if the scsi device is not in running state
> yet. I have attached the patch for scsi_lib.c where I
> do not call get_device if the state is not
> SDEV_RUNNING and similarly do not do put_device if you
> have not done get_device because of the device state.
Ah, I'm sorry, warning light goes off.
The patch is designed to operate on top of Mike Anderson's rework of our
device initialisation code.
http://marc.theaimsgroup.com/?l=linux-scsi&m=106810957502435&w=2
The get_device in the request function causes the badness without this
other patch.
Mike hasn't yet posted an update (hey, this is a hint, Mike) otherwise I
would already have folded it into the bugfixes tree.
James
next prev parent reply other threads:[~2003-11-20 19:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-11-18 2:48 scsi_report_lun_scan bug? Amit Patel
2003-11-18 2:54 ` Matthew Wilcox
2003-11-18 3:10 ` Amit Patel
2003-11-18 5:52 ` Patrick Mansfield
2003-11-18 7:00 ` Andrew Morton
2003-11-18 7:42 ` Amit Patel
2003-11-20 1:56 ` State Model for scsi device badness Amit Patel
2003-11-20 19:01 ` State Model for scsi device badness PATCH Amit Patel
2003-11-20 19:02 ` James Bottomley [this message]
2003-11-21 2:37 ` Mike Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1069354978.1770.221.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=linux-scsi@vger.kernel.org \
--cc=patelamitv@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox