public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@steeleye.com>
To: James Bottomley <James.Bottomley@SteelEye.com>
Cc: Jens Axboe <axboe@suse.de>,
	Patrick Mansfield <patmans@us.ibm.com>,
	SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] Don't retry SG_IO (REQ_BLOCK_PC) commands.
Date: 21 Nov 2003 08:12:29 -0600	[thread overview]
Message-ID: <1069423949.1826.10.camel@mulgrave> (raw)
In-Reply-To: <1069418912.1931.5.camel@mulgrave>

On Fri, 2003-11-21 at 06:48, James Bottomley wrote:
> So the code to add the hints is in the works?

To be more specific:

I think we need to divide the error types up into

1. retryable
2. fatal

and to have at least two, possibly three sources

1. the transport
2. the device
(3. the driver)

so a medium error (say a read failure) is a fatal device error;
something like a no connect would be a fatal transport error, etc.

QUEUE_FULL is a retryable transport error under these terms, but we
might add a third category, flow control, to the error types which it
would more properly fall under.

the entity setting REQ_FASTFAIL should be able to indicate what type of
errors it is interested in (allowing others to be handled
automatically).

James





  reply	other threads:[~2003-11-21 14:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-11-20 16:55 [PATCH] Don't retry SG_IO (REQ_BLOCK_PC) commands Patrick Mansfield
2003-11-20 18:15 ` Mike Anderson
2003-11-20 19:16   ` Jens Axboe
2003-11-20 21:51     ` Patrick Mansfield
2003-11-21 10:17       ` Jens Axboe
2003-11-21 12:48         ` James Bottomley
2003-11-21 14:12           ` James Bottomley [this message]
2003-11-22 23:00             ` Andries Brouwer
2003-11-21 16:26           ` Patrick Mansfield
2003-11-21 18:23             ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1069423949.1826.10.camel@mulgrave \
    --to=james.bottomley@steeleye.com \
    --cc=axboe@suse.de \
    --cc=linux-scsi@vger.kernel.org \
    --cc=patmans@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox