From: James Bottomley <James.Bottomley@steeleye.com>
To: SCSI Mailing List <linux-scsi@vger.kernel.org>,
Pete Clements <clem@clem.clem-digital.net>,
Fabio Coatti <cova@ferrara.linux.it>,
Zwane Mwaikambo <zwane@arm.linux.org.uk>
Cc: Christoph Hellwig <hch@lst.de>
Subject: Fix for aic7xxx problems in BK latest
Date: 23 Nov 2003 23:53:20 -0600 [thread overview]
Message-ID: <1069653204.2066.25.camel@mulgrave> (raw)
It turns out the scsi_device refcounting and list lockdown altered the
conditions under which scsi_report_bus_reset() works, since it calls
shost_for_each_device, which now takes the host lock, that lock cannot
be held while calling the report functions. However, the assumption by
aic is that it can.
I fixed the problem by using the no lock version of the iterator.
James
===== drivers/scsi/scsi_error.c 1.65 vs edited =====
--- 1.65/drivers/scsi/scsi_error.c Sun Sep 21 12:49:36 2003
+++ edited/drivers/scsi/scsi_error.c Sun Nov 23 23:39:09 2003
@@ -1622,7 +1622,7 @@
{
struct scsi_device *sdev;
- shost_for_each_device(sdev, shost) {
+ __shost_for_each_device(sdev, shost) {
if (channel == sdev->channel) {
sdev->was_reset = 1;
sdev->expecting_cc_ua = 1;
@@ -1656,7 +1656,7 @@
{
struct scsi_device *sdev;
- shost_for_each_device(sdev, shost) {
+ __shost_for_each_device(sdev, shost) {
if (channel == sdev->channel &&
target == sdev->id) {
sdev->was_reset = 1;
next reply other threads:[~2003-11-24 5:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-11-24 5:53 James Bottomley [this message]
2003-11-24 7:18 ` Fix for aic7xxx problems in BK latest Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1069653204.2066.25.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=clem@clem.clem-digital.net \
--cc=cova@ferrara.linux.it \
--cc=hch@lst.de \
--cc=linux-scsi@vger.kernel.org \
--cc=zwane@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox