From: James Bottomley <James.Bottomley@steeleye.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Andrew Morton <akpm@osdl.org>,
"Justin T. Gibbs" <gibbs@scsiguy.com>,
SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: aic7xxx deadlock in 2.6.0-test10
Date: 24 Nov 2003 09:08:47 -0600 [thread overview]
Message-ID: <1069686529.1836.6.camel@mulgrave> (raw)
In-Reply-To: <20031124081319.A29562@infradead.org>
On Mon, 2003-11-24 at 02:13, Christoph Hellwig wrote:
> jejb just posted another fix for it on linux-scsi, but in fact your fix
> looks better to me, ahc_initialize doesn't need the host_lock because
> ahc can't be reached from an other thread yet.
I don't think so. This only fixes the boot case for aic7xxx (the boot
problem is also present in aic79xx). This routine was designed to be
called also when a driver detects a reset it didn't initiate
(aic7xxx_old is probably the only driver that actually seems to do
this). In that case, the detection is called from the ISR, so you don't
want to drop the lock
The fix, I think, is to require the lock be held for the bus/device
reset reporting callbacks and use the unlocked iterator.
James
prev parent reply other threads:[~2003-11-24 15:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-11-24 7:08 aic7xxx deadlock in 2.6.0-test10 Andrew Morton
2003-11-24 8:13 ` Christoph Hellwig
2003-11-24 15:08 ` James Bottomley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1069686529.1836.6.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=akpm@osdl.org \
--cc=gibbs@scsiguy.com \
--cc=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox