Linux SCSI subsystem development
 help / color / mirror / Atom feed
From: Damien Le Moal <dlemoal@kernel.org>
To: Niklas Cassel <cassel@kernel.org>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	"Martin K. Petersen" <mkp@kernel.org>
Cc: linux-scsi@vger.kernel.org, John Garry <john.garry@linux.dev>
Subject: Re: [PATCH v4 01/10] scsi: scsi_debug: Refuse a zoned device with a non-zero lowest aligned LBA
Date: Fri, 18 Sep 2026 16:26:15 +0700	[thread overview]
Message-ID: <1071f4a1-eb73-45cc-ac71-e1f195432b63@kernel.org> (raw)
In-Reply-To: <20260918062910.1709791-13-cassel@kernel.org>

On 2026/09/18 13:29, Niklas Cassel wrote:
> The LOWEST ALIGNED LOGICAL BLOCK ADDRESS field indicates the LBA of the
> first logical block that is located at the beginning of a physical
> block, see SBC-6 r02 (T10/BSR INCITS 587), 5.20.2. scsi_debug reports
> the lowest_aligned module parameter in that field of the READ CAPACITY
> (16) parameter data, but nothing else in the driver acts on it: the data
> it stores begins at LBA 0 and has no physical block structure behind it.
> 
> That does not matter for a device that is not zoned, where a write need
> not end on a physical block boundary at all. It does matter for a zoned
> device: ZBC requires a write to a sequential write required zone to end
> on a physical block boundary, and a zone begins at a multiple of the
> zone size, so a non-zero lowest aligned LBA puts the beginning of every
> zone in the middle of a physical block. A host that writes in units of
> the zone write granularity that it was given can then never satisfy the
> requirement, and such a zone cannot be written at all.
> 
> Refuse the combination rather than emulate a device that cannot be used.
> 
> Assisted-by: LLM
> Signed-off-by: Niklas Cassel <cassel@kernel.org>

Looks good.

Reviewed-by: Damien Le Moal <dlemoal@kernel.org>

-- 
Damien Le Moal
Western Digital Research

  reply	other threads:[~2026-09-18  9:26 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-18  6:29 [PATCH v4 00/10] scsi: scsi_debug: fix zoned write validation Niklas Cassel
2026-09-18  6:29 ` [PATCH v4 01/10] scsi: scsi_debug: Refuse a zoned device with a non-zero lowest aligned LBA Niklas Cassel
2026-09-18  9:26   ` Damien Le Moal [this message]
2026-09-18  6:29 ` [PATCH v4 02/10] scsi: scsi_debug: Make atomic writes and ZBC emulation mutually exclusive Niklas Cassel
2026-09-18  7:21   ` John Garry
2026-09-18  9:26   ` Damien Le Moal
2026-09-18  6:29 ` [PATCH v4 03/10] scsi: scsi_debug: Take the zone metadata lock before the data lock Niklas Cassel
2026-09-18  9:28   ` Damien Le Moal
2026-09-18  6:29 ` [PATCH v4 04/10] scsi: scsi_debug: Evaluate scsi_debug_lbp() only once Niklas Cassel
2026-09-18  9:29   ` Damien Le Moal
2026-09-18  6:29 ` [PATCH v4 05/10] scsi: scsi_debug: Report the residual of a write Niklas Cassel
2026-09-18  6:29 ` [PATCH v4 06/10] scsi: scsi_debug: Enforce physical block alignment of zoned writes Niklas Cassel
2026-09-18  6:29 ` [PATCH v4 07/10] scsi: scsi_debug: Do not write a partial physical block to a zoned device Niklas Cassel
2026-09-18  9:31   ` Damien Le Moal
2026-09-18 10:25     ` Niklas Cassel
2026-09-18  6:29 ` [PATCH v4 08/10] scsi: scsi_debug: Advance the write pointer over the data written Niklas Cassel
2026-09-18  6:29 ` [PATCH v4 09/10] scsi: scsi_debug: Map the region written by WRITE ATOMIC (16) Niklas Cassel
2026-09-18  7:29   ` John Garry
2026-09-18  8:09     ` Niklas Cassel
2026-09-18  6:29 ` [PATCH v4 10/10] scsi: scsi_debug: Validate the access parameters of " Niklas Cassel
2026-09-18  7:33   ` John Garry
2026-09-18  7:53     ` Niklas Cassel
2026-09-18  8:19       ` John Garry
2026-09-18  8:55         ` Niklas Cassel
2026-09-18  9:32   ` Damien Le Moal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1071f4a1-eb73-45cc-ac71-e1f195432b63@kernel.org \
    --to=dlemoal@kernel.org \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=cassel@kernel.org \
    --cc=john.garry@linux.dev \
    --cc=linux-scsi@vger.kernel.org \
    --cc=mkp@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox