From: Arjan van de Ven <arjanv@redhat.com>
To: Eric Moore <emoore@lsil.com>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
'James.Bottomley@steeleye.com'
Subject: Re: [PATCH] 2.6.1-rc2 - MPT Fusion driver 3.00.00 update
Date: Wed, 07 Jan 2004 09:55:49 +0100 [thread overview]
Message-ID: <1073465748.4429.3.camel@laptop.fenrus.com> (raw)
In-Reply-To: <3FFB4E0F.704@lsil.com>
[-- Attachment #1: Type: text/plain, Size: 1249 bytes --]
On Wed, 2004-01-07 at 01:08, Eric Moore wrote:
> +/**************************************************************************
> + * Power Management
> + */
> +#ifdef CONFIG_PM
> +#include <acpi/acpi_drivers.h>
> +
> +/*=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=*/
> +/*
> + * mptbase_suspend - Fusion MPT base driver suspend routine.
> + *
> + *
> + */
> +static int mptbase_suspend(struct pci_dev *pdev, u32 state)
> +{
> + u32 device_state;
> + MPT_ADAPTER *ioc = pci_get_drvdata(pdev);
> +
> + switch(state)
> + {
> + case ACPI_STATE_S1:
this looks really really wrong. Linux suspend and resume are absolutely
not acpi specific and drivers should not use ACPI specific defines that
also just may mean something different than the linux API means!
> @@ -264,12 +298,14 @@
> mptscsih_io_direction(Scsi_Cmnd *cmd)
why can't you use the scsi layer IO direction function ???
>
> +#ifndef MPTSCSIH_DISABLE_DOMAIN_VALIDATION
> + mpt_dv_deregister(MPTSCSIH_DRIVER);
> +#endif
I would suggest making mpt_dv_deregister() and co a nop in the DISABLE
case, that way you don't need ifdefs all over the driver but just around
the entire functions....
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2004-01-07 8:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-07 0:08 [PATCH] 2.6.1-rc2 - MPT Fusion driver 3.00.00 update Eric Moore
2004-01-07 4:40 ` Matt Domsch
2004-01-07 8:55 ` Arjan van de Ven [this message]
2004-01-07 9:58 ` Christoph Hellwig
2004-01-07 17:09 ` Matthew Wilcox
-- strict thread matches above, loose matches on Subject: below --
2004-01-07 16:11 Moore, Eric Dean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1073465748.4429.3.camel@laptop.fenrus.com \
--to=arjanv@redhat.com \
--cc='James.Bottomley@steeleye.com' \
--cc=emoore@lsil.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox