Re: Kernel oops in 2.6.1 when loading aha152x_cs.ko

[Eric Kerin <eric@bootseg.com>]

On Fri, 2004-01-09 at 15:14, Larry W. Finger wrote: 
> +			INIT_LIST_HEAD(&sht->legacy_hosts);

Under the non-pcmcia version of that driver, the above code is handled
by the module_init function (which is included from scsi_module.c), but
since that routine isn't used for the PCMCIA version, that list never
get's initialized.

The below patch handles it in the aha152x driver itself for PCMCIA(which
is the part that is technically broken). Instead of handling it in
hosts.c file.

Give this a try, it should work the same, but I don't have the hardware
to test it on.

Eric


-- linux-2.6.1/drivers/scsi/aha152x.c   2003-12-31 11:04:14.000000000
-0500
+++ linux-2.6.1/drivers/scsi/aha152x.c.listfix   2004-01-09
16:21:03.977748000 -0500
@@ -965,6 +965,12 @@ struct Scsi_Host *aha152x_probe_one(stru
{
        struct Scsi_Host *shpnt;

+#ifdef PCMCIA
+       if(!&aha152x_driver_template->legacy_hosts){
+               INIT_LIST_HEAD(&aha152x_driver_template->legacy_hosts);
+       }
+#endif
+
        shpnt = scsi_register(&aha152x_driver_template, sizeof(struct 
aha152x_hostdata));
        if (!shpnt) {
                printk(KERN_ERR "aha152x: scsi_register failed\n");